Skip to content

Commit 8c94bdb

Browse files
Treehugger RobotAndroid (Google) Code Review
authored andcommitted
Merge "Remove redundant isSplit assignments" into main
2 parents 94b29e5 + 89c429f commit 8c94bdb

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

services/inputflinger/dispatcher/InputDispatcher.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2412,7 +2412,7 @@ InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, const Motio
24122412
tempTouchState = *oldState;
24132413
}
24142414

2415-
bool isSplit = shouldSplitTouch(entry.source);
2415+
const bool isSplit = shouldSplitTouch(entry.source);
24162416

24172417
const bool isHoverAction = (maskedAction == AMOTION_EVENT_ACTION_HOVER_MOVE ||
24182418
maskedAction == AMOTION_EVENT_ACTION_HOVER_ENTER ||
@@ -2425,11 +2425,6 @@ InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, const Motio
24252425
const bool newGesture = isDown || maskedAction == AMOTION_EVENT_ACTION_SCROLL ||
24262426
maskedAction == AMOTION_EVENT_ACTION_HOVER_ENTER ||
24272427
maskedAction == AMOTION_EVENT_ACTION_HOVER_MOVE;
2428-
const bool isFromMouse = isFromSource(entry.source, AINPUT_SOURCE_MOUSE);
2429-
2430-
if (newGesture) {
2431-
isSplit = false;
2432-
}
24332428

24342429
if (isDown && tempTouchState.hasHoveringPointers(entry.deviceId)) {
24352430
// Compatibility behaviour: ACTION_DOWN causes HOVER_EXIT to get generated.
@@ -2472,8 +2467,6 @@ InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, const Motio
24722467
return injectionError(InputEventInjectionResult::TARGET_MISMATCH);
24732468
}
24742469

2475-
isSplit = !isFromMouse;
2476-
24772470
std::vector<sp<WindowInfoHandle>> newTouchedWindows =
24782471
mWindowInfos.findTouchedSpyWindowsAt(displayId, x, y, isStylus, entry.deviceId,
24792472
mTouchStatesByDisplay);
@@ -2647,7 +2640,6 @@ InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, const Motio
26472640
targets);
26482641

26492642
// Make a slippery entrance into the new window.
2650-
isSplit = !isFromMouse;
26512643

26522644
ftl::Flags<InputTarget::Flags> targetFlags;
26532645
if (canReceiveForegroundTouches(*newTouchedWindowHandle->getInfo())) {

0 commit comments

Comments
 (0)