Skip to content

Commit 8703fd8

Browse files
Treehugger RobotAndroid (Google) Code Review
authored andcommitted
Merge "Address NDK API feedback" into main
2 parents def8ff1 + bd641ac commit 8703fd8

1 file changed

Lines changed: 23 additions & 25 deletions

File tree

include/android/system_health.h

Lines changed: 23 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@ typedef struct AGpuHeadroomParams AGpuHeadroomParams;
8181
*
8282
* @return A new instance of ACpuHeadroomParams.
8383
*/
84-
ACpuHeadroomParams *_Nonnull ACpuHeadroomParams_create()
84+
ACpuHeadroomParams* _Nonnull ACpuHeadroomParams_create(void)
8585
__INTRODUCED_IN(36);
8686

87-
enum ACpuHeadroomCalculationType {
87+
typedef enum ACpuHeadroomCalculationType : int32_t {
8888
/**
8989
* Use the minimum headroom value within the calculation window.
9090
* Introduced in API level 36.
@@ -95,10 +95,9 @@ enum ACpuHeadroomCalculationType {
9595
* Introduced in API level 36.
9696
*/
9797
ACPU_HEADROOM_CALCULATION_TYPE_AVERAGE = 1,
98-
};
99-
typedef enum ACpuHeadroomCalculationType ACpuHeadroomCalculationType;
98+
} ACpuHeadroomCalculationType;
10099

101-
enum AGpuHeadroomCalculationType {
100+
typedef enum AGpuHeadroomCalculationType : int32_t {
102101
/**
103102
* Use the minimum headroom value within the calculation window.
104103
* Introduced in API level 36.
@@ -109,8 +108,7 @@ enum AGpuHeadroomCalculationType {
109108
* Introduced in API level 36.
110109
*/
111110
AGPU_HEADROOM_CALCULATION_TYPE_AVERAGE = 1,
112-
};
113-
typedef enum AGpuHeadroomCalculationType AGpuHeadroomCalculationType;
111+
} AGpuHeadroomCalculationType;
114112

115113
/**
116114
* Sets the headroom calculation window size in ACpuHeadroomParams.
@@ -124,7 +122,7 @@ typedef enum AGpuHeadroomCalculationType AGpuHeadroomCalculationType;
124122
* {@link #ACpuHeadroomParams_getCalculationWindowMillis} if not set. The device
125123
* will try to use the closest feasible window size to this param.
126124
*/
127-
void ACpuHeadroomParams_setCalculationWindowMillis(ACpuHeadroomParams *_Nonnull params,
125+
void ACpuHeadroomParams_setCalculationWindowMillis(ACpuHeadroomParams* _Nonnull params,
128126
int windowMillis)
129127
__INTRODUCED_IN(36);
130128

@@ -136,7 +134,7 @@ __INTRODUCED_IN(36);
136134
* @param params The params to be set.
137135
* @return This will return the default value chosen by the device if the params is not set.
138136
*/
139-
int ACpuHeadroomParams_getCalculationWindowMillis(ACpuHeadroomParams *_Nonnull params)
137+
int ACpuHeadroomParams_getCalculationWindowMillis(ACpuHeadroomParams* _Nonnull params)
140138
__INTRODUCED_IN(36);
141139

142140
/**
@@ -151,7 +149,7 @@ __INTRODUCED_IN(36);
151149
* {@link #AGpuHeadroomParams_getCalculationWindowMillis} if not set. The device
152150
* will try to use the closest feasible window size to this param.
153151
*/
154-
void AGpuHeadroomParams_setCalculationWindowMillis(AGpuHeadroomParams *_Nonnull params,
152+
void AGpuHeadroomParams_setCalculationWindowMillis(AGpuHeadroomParams* _Nonnull params,
155153
int windowMillis)
156154
__INTRODUCED_IN(36);
157155

@@ -163,7 +161,7 @@ __INTRODUCED_IN(36);
163161
* @param params The params to be set.
164162
* @return This will return the default value chosen by the device if the params is not set.
165163
*/
166-
int AGpuHeadroomParams_getCalculationWindowMillis(AGpuHeadroomParams *_Nonnull params)
164+
int AGpuHeadroomParams_getCalculationWindowMillis(AGpuHeadroomParams* _Nonnull params)
167165
__INTRODUCED_IN(36);
168166

169167
/**
@@ -174,7 +172,7 @@ __INTRODUCED_IN(36);
174172
* @param params The params to be set.
175173
* @param calculationType The headroom calculation type.
176174
*/
177-
void ACpuHeadroomParams_setCalculationType(ACpuHeadroomParams *_Nonnull params,
175+
void ACpuHeadroomParams_setCalculationType(ACpuHeadroomParams* _Nonnull params,
178176
ACpuHeadroomCalculationType calculationType)
179177
__INTRODUCED_IN(36);
180178

@@ -187,7 +185,7 @@ __INTRODUCED_IN(36);
187185
* @return The headroom calculation type.
188186
*/
189187
ACpuHeadroomCalculationType
190-
ACpuHeadroomParams_getCalculationType(ACpuHeadroomParams *_Nonnull params)
188+
ACpuHeadroomParams_getCalculationType(ACpuHeadroomParams* _Nonnull params)
191189
__INTRODUCED_IN(36);
192190

193191
/**
@@ -198,7 +196,7 @@ __INTRODUCED_IN(36);
198196
* @param params The params to be set.
199197
* @param calculationType The headroom calculation type.
200198
*/
201-
void AGpuHeadroomParams_setCalculationType(AGpuHeadroomParams *_Nonnull params,
199+
void AGpuHeadroomParams_setCalculationType(AGpuHeadroomParams* _Nonnull params,
202200
AGpuHeadroomCalculationType calculationType)
203201
__INTRODUCED_IN(36);
204202

@@ -211,7 +209,7 @@ __INTRODUCED_IN(36);
211209
* @return The headroom calculation type.
212210
*/
213211
AGpuHeadroomCalculationType
214-
AGpuHeadroomParams_getCalculationType(AGpuHeadroomParams *_Nonnull params)
212+
AGpuHeadroomParams_getCalculationType(AGpuHeadroomParams* _Nonnull params)
215213
__INTRODUCED_IN(36);
216214

217215
/**
@@ -223,7 +221,7 @@ __INTRODUCED_IN(36);
223221
* @param tids Non-null array of TIDs, maximum 5.
224222
* @param tidsSize The size of the tids array.
225223
*/
226-
void ACpuHeadroomParams_setTids(ACpuHeadroomParams *_Nonnull params, const int *_Nonnull tids,
224+
void ACpuHeadroomParams_setTids(ACpuHeadroomParams* _Nonnull params, const int* _Nonnull tids,
227225
int tidsSize)
228226
__INTRODUCED_IN(36);
229227

@@ -238,7 +236,7 @@ __INTRODUCED_IN(36);
238236
*
239237
* @return A new instance of AGpuHeadroomParams.
240238
*/
241-
AGpuHeadroomParams *_Nonnull AGpuHeadroomParams_create()
239+
AGpuHeadroomParams* _Nonnull AGpuHeadroomParams_create(void)
242240
__INTRODUCED_IN(36);
243241

244242
/**
@@ -248,7 +246,7 @@ __INTRODUCED_IN(36);
248246
*
249247
* @param params The params to be deleted.
250248
*/
251-
void ACpuHeadroomParams_destroy(ACpuHeadroomParams *_Nonnull params)
249+
void ACpuHeadroomParams_destroy(ACpuHeadroomParams* _Nonnull params)
252250
__INTRODUCED_IN(36);
253251

254252
/**
@@ -258,7 +256,7 @@ __INTRODUCED_IN(36);
258256
*
259257
* @param params The params to be deleted.
260258
*/
261-
void AGpuHeadroomParams_destroy(AGpuHeadroomParams *_Nonnull params)
259+
void AGpuHeadroomParams_destroy(AGpuHeadroomParams* _Nonnull params)
262260
__INTRODUCED_IN(36);
263261

264262
/**
@@ -282,8 +280,8 @@ __INTRODUCED_IN(36);
282280
* EPERM if the TIDs do not belong to the same process.
283281
* ENOTSUP if API or requested params is unsupported.
284282
*/
285-
int ASystemHealth_getCpuHeadroom(const ACpuHeadroomParams *_Nullable params,
286-
float *_Nonnull outHeadroom)
283+
int ASystemHealth_getCpuHeadroom(const ACpuHeadroomParams* _Nullable params,
284+
float* _Nonnull outHeadroom)
287285
__INTRODUCED_IN(36);
288286

289287
/**
@@ -306,8 +304,8 @@ __INTRODUCED_IN(36);
306304
* EPIPE if failed to get the GPU headroom.
307305
* ENOTSUP if API or requested params is unsupported.
308306
*/
309-
int ASystemHealth_getGpuHeadroom(const AGpuHeadroomParams *_Nullable params,
310-
float *_Nonnull outHeadroom)
307+
int ASystemHealth_getGpuHeadroom(const AGpuHeadroomParams* _Nullable params,
308+
float* _Nonnull outHeadroom)
311309
__INTRODUCED_IN(36);
312310

313311
/**
@@ -323,7 +321,7 @@ __INTRODUCED_IN(36);
323321
* EPIPE if failed to get the minimum polling interval.
324322
* ENOTSUP if API is unsupported.
325323
*/
326-
int ASystemHealth_getCpuHeadroomMinIntervalMillis(int64_t *_Nonnull outMinIntervalMillis)
324+
int ASystemHealth_getCpuHeadroomMinIntervalMillis(int64_t* _Nonnull outMinIntervalMillis)
327325
__INTRODUCED_IN(36);
328326

329327
/**
@@ -339,7 +337,7 @@ __INTRODUCED_IN(36);
339337
* EPIPE if failed to get the minimum polling interval.
340338
* ENOTSUP if API is unsupported.
341339
*/
342-
int ASystemHealth_getGpuHeadroomMinIntervalMillis(int64_t *_Nonnull outMinIntervalMillis)
340+
int ASystemHealth_getGpuHeadroomMinIntervalMillis(int64_t* _Nonnull outMinIntervalMillis)
343341
__INTRODUCED_IN(36);
344342

345343
#ifdef __cplusplus

0 commit comments

Comments
 (0)