servicemanager: set consistent flags for self-reg

Steven Moreland · Steven Moreland · commit 6c86b6c926ab · 2024-12-06T23:57:34.000Z
SM has special flags set to become a context object, but
these were not set when it registers as itself.

Bug: 382775095
Test: boot w/ harsher checks
Merged-In: I0fb567cbcca67a2fc6c088f652c8af570b8d7e53
Change-Id: I0fb567cbcca67a2fc6c088f652c8af570b8d7e53
diff --git a/cmds/servicemanager/main.cpp b/cmds/servicemanager/main.cpp
@@ -122,6 +122,7 @@ int main(int argc, char** argv) {
     ps->setCallRestriction(ProcessState::CallRestriction::FATAL_IF_NOT_ONEWAY);
 
     sp<ServiceManager> manager = sp<ServiceManager>::make(std::make_unique<Access>());
+    manager->setRequestingSid(true);
     if (!manager->addService("manager", manager, false /*allowIsolated*/, IServiceManager::DUMP_FLAG_PRIORITY_DEFAULT).isOk()) {
         LOG(ERROR) << "Could not self register servicemanager";
     }

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,7 @@ int main(int argc, char** argv) {`
`122`	`122`	`ps->setCallRestriction(ProcessState::CallRestriction::FATAL_IF_NOT_ONEWAY);`
`123`	`123`
`124`	`124`	`sp<ServiceManager> manager = sp<ServiceManager>::make(std::make_unique<Access>());`
	`125`	`+ manager->setRequestingSid(true);`
`125`	`126`	`if (!manager->addService("manager", manager, false /allowIsolated/, IServiceManager::DUMP_FLAG_PRIORITY_DEFAULT).isOk()) {`
`126`	`127`	`LOG(ERROR) << "Could not self register servicemanager";`
`127`	`128`	`}`