Skip to content

Commit 56cea28

Browse files
Treehugger Robotandroid-build-merge-worker-robot
authored andcommitted
Merge "Remove the extra parameters in onCommitNotComposited" into main am: 13acbe3
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/3359406 Change-Id: I2a6d9970b213f88664eb9b6ae4735b0bfb62e6d1 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2 parents 9cd4f72 + 13acbe3 commit 56cea28

5 files changed

Lines changed: 6 additions & 6 deletions

File tree

services/surfaceflinger/Scheduler/ISchedulerCallback.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ struct ISchedulerCallback {
3131
virtual void onChoreographerAttached() = 0;
3232
virtual void onExpectedPresentTimePosted(TimePoint, ftl::NonNull<DisplayModePtr>,
3333
Fps renderRate) = 0;
34-
virtual void onCommitNotComposited(PhysicalDisplayId pacesetterDisplayId) = 0;
34+
virtual void onCommitNotComposited() = 0;
3535
virtual void vrrDisplayIdle(bool idle) = 0;
3636

3737
protected:

services/surfaceflinger/Scheduler/Scheduler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ void Scheduler::onFrameSignal(ICompositor& compositor, VsyncId vsyncId,
238238
if (FlagManager::getInstance().vrr_config()) {
239239
compositor.sendNotifyExpectedPresentHint(pacesetterPtr->displayId);
240240
}
241-
mSchedulerCallback.onCommitNotComposited(pacesetterPtr->displayId);
241+
mSchedulerCallback.onCommitNotComposited();
242242
return;
243243
}
244244
}

services/surfaceflinger/SurfaceFlinger.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4257,7 +4257,7 @@ void SurfaceFlinger::sendNotifyExpectedPresentHint(PhysicalDisplayId displayId)
42574257
scheduleNotifyExpectedPresentHint(displayId);
42584258
}
42594259

4260-
void SurfaceFlinger::onCommitNotComposited(PhysicalDisplayId pacesetterDisplayId) {
4260+
void SurfaceFlinger::onCommitNotComposited() {
42614261
if (FlagManager::getInstance().commit_not_composited()) {
42624262
mFrameTimeline->onCommitNotComposited();
42634263
}

services/surfaceflinger/SurfaceFlinger.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ class SurfaceFlinger : public BnSurfaceComposer,
691691
void onChoreographerAttached() override;
692692
void onExpectedPresentTimePosted(TimePoint expectedPresentTime, ftl::NonNull<DisplayModePtr>,
693693
Fps renderRate) override;
694-
void onCommitNotComposited(PhysicalDisplayId pacesetterDisplayId) override
694+
void onCommitNotComposited() override
695695
REQUIRES(kMainThreadContext);
696696
void vrrDisplayIdle(bool idle) override;
697697

services/surfaceflinger/tests/unittests/mock/MockSchedulerCallback.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ struct SchedulerCallback final : ISchedulerCallback {
2929
MOCK_METHOD(void, onChoreographerAttached, (), (override));
3030
MOCK_METHOD(void, onExpectedPresentTimePosted, (TimePoint, ftl::NonNull<DisplayModePtr>, Fps),
3131
(override));
32-
MOCK_METHOD(void, onCommitNotComposited, (PhysicalDisplayId), (override));
32+
MOCK_METHOD(void, onCommitNotComposited, (), (override));
3333
MOCK_METHOD(void, vrrDisplayIdle, (bool), (override));
3434
};
3535

@@ -39,7 +39,7 @@ struct NoOpSchedulerCallback final : ISchedulerCallback {
3939
void kernelTimerChanged(bool) override {}
4040
void onChoreographerAttached() override {}
4141
void onExpectedPresentTimePosted(TimePoint, ftl::NonNull<DisplayModePtr>, Fps) override {}
42-
void onCommitNotComposited(PhysicalDisplayId) override {}
42+
void onCommitNotComposited() override {}
4343
void vrrDisplayIdle(bool) override {}
4444
};
4545

0 commit comments

Comments
 (0)