Skip to content

Commit 54392a5

Browse files
Treehugger RobotGerrit Code Review
authored andcommitted
Merge "Clean up a workaround for product variants" into main
2 parents 24abe44 + 163415a commit 54392a5

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

libs/binder/ndk/include_cpp/android/binder_interface_utils.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#include <android/binder_auto_utils.h>
3131
#include <android/binder_ibinder.h>
3232

33-
#if defined(__ANDROID_VENDOR__)
33+
#if defined(__ANDROID_VENDOR_API__)
3434
#include <android/llndk-versioning.h>
3535
#elif !defined(API_LEVEL_AT_LEAST)
3636
#if defined(__BIONIC__)
@@ -39,7 +39,7 @@
3939
#else
4040
#define API_LEVEL_AT_LEAST(sdk_api_level, vendor_api_level) (true)
4141
#endif // __BIONIC__
42-
#endif // __ANDROID_VENDOR__
42+
#endif // __ANDROID_VENDOR_API__
4343

4444
#if __has_include(<android/binder_shell.h>)
4545
#include <android/binder_shell.h>
@@ -297,9 +297,7 @@ AIBinder_Class* ICInterface::defineClass(const char* interfaceDescriptor,
297297
}
298298
#endif
299299

300-
// TODO(b/368559337): fix versioning on product partition
301-
#if !defined(__ANDROID_PRODUCT__) && \
302-
(defined(__ANDROID_UNAVAILABLE_SYMBOLS_ARE_WEAK__) || __ANDROID_API__ >= 36)
300+
#if defined(__ANDROID_UNAVAILABLE_SYMBOLS_ARE_WEAK__) || __ANDROID_API__ >= 36
303301
if API_LEVEL_AT_LEAST (36, 202504) {
304302
if (codeToFunction != nullptr) {
305303
AIBinder_Class_setTransactionCodeToFunctionNameMap(clazz, codeToFunction,

libs/binder/ndk/include_cpp/android/persistable_bundle_aidl.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
#include <set>
2323
#include <sstream>
2424

25-
// Include llndk-versioning.h only for vendor build as it is not available for NDK headers.
26-
#if defined(__ANDROID_VENDOR__)
25+
// Include llndk-versioning.h only for non-system build as it is not available for NDK headers.
26+
#if defined(__ANDROID_VENDOR_API__)
2727
#include <android/llndk-versioning.h>
2828
#elif !defined(API_LEVEL_AT_LEAST)
2929
#if defined(__BIONIC__)
@@ -32,7 +32,7 @@
3232
#else
3333
#define API_LEVEL_AT_LEAST(sdk_api_level, vendor_api_level) (true)
3434
#endif // __BIONIC__
35-
#endif // __ANDROID_VENDOR__
35+
#endif // __ANDROID_VENDOR_API__
3636

3737
namespace aidl::android::os {
3838

0 commit comments

Comments
 (0)