Fix the issue of screen flashing when adjusting ambient light when playing HDR video.

zhengchuanlong · chuanlong zheng · commit 47d29884515e · 2025-02-24T22:50:56.000-08:00
Bug:360380695
Test:Manual

The comparison operation comment of the LayerSettings.h file describes "Keep in sync with custom comparison function in compositionengine/impl/ClientCompositionRequestCache.cpp". However, for the comparison of LayerSetting, white point value comparison is added in LayerSettings.h, but not in ClientCompositionRequestCache.cpp, which makes the HDR video dimming cache ineffective and causes screen flickering.

Change-Id: I54d230ddf176660c5e83f771a59154debce7f541
Signed-off-by: zhengchuanlong &lt;zhengchuanlong@xiaomi.com&gt;
diff --git a/services/surfaceflinger/CompositionEngine/src/ClientCompositionRequestCache.cpp b/services/surfaceflinger/CompositionEngine/src/ClientCompositionRequestCache.cpp
@@ -38,7 +38,8 @@ inline bool equalIgnoringSource(const renderengine::LayerSettings& lhs,
             lhs.disableBlending == rhs.disableBlending && lhs.shadow == rhs.shadow &&
             lhs.backgroundBlurRadius == rhs.backgroundBlurRadius &&
             lhs.stretchEffect == rhs.stretchEffect &&
-            lhs.edgeExtensionEffect == rhs.edgeExtensionEffect;
+            lhs.edgeExtensionEffect == rhs.edgeExtensionEffect &&
+            lhs.whitePointNits == rhs.whitePointNits;
 }
 
 inline bool equalIgnoringBuffer(const renderengine::Buffer& lhs, const renderengine::Buffer& rhs) {

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,8 @@ inline bool equalIgnoringSource(const renderengine::LayerSettings& lhs,`
`38`	`38`	`lhs.disableBlending == rhs.disableBlending && lhs.shadow == rhs.shadow &&`
`39`	`39`	`lhs.backgroundBlurRadius == rhs.backgroundBlurRadius &&`
`40`	`40`	`lhs.stretchEffect == rhs.stretchEffect &&`
`41`		`- lhs.edgeExtensionEffect == rhs.edgeExtensionEffect;`
	`41`	`+ lhs.edgeExtensionEffect == rhs.edgeExtensionEffect &&`
	`42`	`+ lhs.whitePointNits == rhs.whitePointNits;`
`42`	`43`	`}`
`43`	`44`
`44`	`45`	`inline bool equalIgnoringBuffer(const renderengine::Buffer& lhs, const renderengine::Buffer& rhs) {`