Skip to content

Commit 42a6b62

Browse files
author
Shuangxi Xiang
committed
Remove redundant local parameters in Client
The Android version upgrade modified the declaration of createLayer and mirrorLayer functions in SurfaceFlinger, removed multiple parameters of objects such as IBinder, and also modified the mirrorDisplay function in Client, causing their local variables sp<IBinder> handle to be redundant. Signed-off-by: Shuangxi Xiang <xiangshuangxi@xiaomi.corp-partner.google.com> Change-Id: Ifa8db1993fa46209a9d935c9ff588d2d0dc4c5f8
1 parent 33a6e89 commit 42a6b62

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

services/surfaceflinger/Client.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ binder::Status Client::createSurface(const std::string& name, int32_t flags,
5353
const sp<IBinder>& parent, const gui::LayerMetadata& metadata,
5454
gui::CreateSurfaceResult* outResult) {
5555
// We rely on createLayer to check permissions.
56-
sp<IBinder> handle;
5756
LayerCreationArgs args(mFlinger.get(), sp<Client>::fromExisting(this), name.c_str(),
5857
static_cast<uint32_t>(flags), std::move(metadata));
5958
args.parentHandle = parent;
@@ -101,15 +100,13 @@ binder::Status Client::getLayerFrameStats(const sp<IBinder>& handle, gui::FrameS
101100

102101
binder::Status Client::mirrorSurface(const sp<IBinder>& mirrorFromHandle,
103102
gui::CreateSurfaceResult* outResult) {
104-
sp<IBinder> handle;
105103
LayerCreationArgs args(mFlinger.get(), sp<Client>::fromExisting(this), "MirrorRoot",
106104
0 /* flags */, gui::LayerMetadata());
107105
status_t status = mFlinger->mirrorLayer(args, mirrorFromHandle, *outResult);
108106
return binderStatusFromStatusT(status);
109107
}
110108

111109
binder::Status Client::mirrorDisplay(int64_t displayId, gui::CreateSurfaceResult* outResult) {
112-
sp<IBinder> handle;
113110
LayerCreationArgs args(mFlinger.get(), sp<Client>::fromExisting(this),
114111
"MirrorRoot-" + std::to_string(displayId), 0 /* flags */,
115112
gui::LayerMetadata());

0 commit comments

Comments
 (0)