Skip to content

Commit 3b2e421

Browse files
AndroidMatt1Android (Google) Code Review
authored andcommitted
Merge "Remove FrameTimeline module and build FrameTimeline.cpp with SF" into main
2 parents c2e1ba6 + 3495323 commit 3b2e421

8 files changed

Lines changed: 14 additions & 50 deletions

File tree

services/surfaceflinger/Android.bp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ cc_defaults {
9393
"iinputflinger_aidl_lib_static",
9494
"libaidlcommonsupport",
9595
"libcompositionengine",
96-
"libframetimeline",
9796
"libgui_aidl_static",
9897
"libperfetto_client_experimental",
9998
"librenderengine",
@@ -208,6 +207,7 @@ filegroup {
208207
"DisplayDevice.cpp",
209208
"Effects/Daltonizer.cpp",
210209
"FpsReporter.cpp",
210+
"FrameTimeline/FrameTimeline.cpp",
211211
"FrameTracer/FrameTracer.cpp",
212212
"FrameTracker.cpp",
213213
"FrontEnd/LayerCreationArgs.cpp",

services/surfaceflinger/FrameTimeline/Android.bp

Lines changed: 0 additions & 35 deletions
This file was deleted.

services/surfaceflinger/Layer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464

6565
#include "DisplayDevice.h"
6666
#include "DisplayHardware/HWComposer.h"
67-
#include "FrameTimeline.h"
67+
#include "FrameTimeline/FrameTimeline.h"
6868
#include "FrameTracer/FrameTracer.h"
6969
#include "FrontEnd/LayerCreationArgs.h"
7070
#include "FrontEnd/LayerHandle.h"

services/surfaceflinger/Scheduler/EventThread.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
#include <common/FlagManager.h>
4646
#include <scheduler/FrameRateMode.h>
4747
#include <scheduler/VsyncConfig.h>
48-
#include "FrameTimeline.h"
48+
#include "FrameTimeline/FrameTimeline.h"
4949
#include "VSyncDispatch.h"
5050

5151
#include "EventThread.h"

services/surfaceflinger/Scheduler/MessageQueue.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#include <scheduler/interface/ICompositor.h>
2525

2626
#include "EventThread.h"
27-
#include "FrameTimeline.h"
27+
#include "FrameTimeline/FrameTimeline.h"
2828
#include "MessageQueue.h"
2929

3030
namespace android::impl {

services/surfaceflinger/tests/unittests/Android.bp

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ filegroup {
6565
"mock/MockFrameTracer.cpp",
6666
"mock/MockNativeWindowSurface.cpp",
6767
"mock/MockTimeStats.cpp",
68-
"mock/MockVsyncController.cpp",
6968
"mock/MockVSyncDispatch.cpp",
7069
"mock/MockVSyncTracker.cpp",
70+
"mock/MockVsyncController.cpp",
7171
],
7272
}
7373

@@ -87,10 +87,10 @@ cc_test {
8787
test_suites: ["device-tests"],
8888
header_libs: ["surfaceflinger_tests_common_headers"],
8989
srcs: [
90+
"*.cpp",
9091
":libsurfaceflinger_backend_mock_sources",
9192
":libsurfaceflinger_mock_sources",
9293
":libsurfaceflinger_sources",
93-
"*.cpp",
9494
],
9595
}
9696

@@ -117,9 +117,8 @@ cc_defaults {
117117
"android.hardware.power@1.2",
118118
"android.hardware.power@1.3",
119119
"libaidlcommonsupport",
120-
"libcompositionengine_mocks",
121120
"libcompositionengine",
122-
"libframetimeline",
121+
"libcompositionengine_mocks",
123122
"libgmock",
124123
"libgui_mocks",
125124
"libperfetto_client_experimental",
@@ -140,14 +139,15 @@ cc_defaults {
140139
"android.hardware.graphics.allocator@2.0",
141140
"android.hardware.graphics.allocator@3.0",
142141
"android.hardware.graphics.common@1.2",
142+
"libEGL",
143+
"libGLESv1_CM",
144+
"libGLESv2",
145+
"libSurfaceFlingerProp",
143146
"libbase",
144147
"libbinder",
145148
"libbinder_ndk",
146149
"libcutils",
147-
"libEGL",
148150
"libfmq",
149-
"libGLESv1_CM",
150-
"libGLESv2",
151151
"libgui",
152152
"libhidlbase",
153153
"libinput",
@@ -157,11 +157,10 @@ cc_defaults {
157157
"libprocessgroup",
158158
"libprotobuf-cpp-lite",
159159
"libstatslog_surfaceflinger",
160-
"libSurfaceFlingerProp",
161160
"libsync",
161+
"libtracing_perfetto",
162162
"libui",
163163
"libutils",
164-
"libtracing_perfetto",
165164
],
166165
header_libs: [
167166
"android.hardware.graphics.composer3-command-buffer",

services/surfaceflinger/tests/unittests/EventThreadTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
#include "AsyncCallRecorder.h"
3232
#include "DisplayHardware/DisplayMode.h"
33-
#include "FrameTimeline.h"
33+
#include "FrameTimeline/FrameTimeline.h"
3434
#include "Scheduler/EventThread.h"
3535
#include "mock/MockVSyncDispatch.h"
3636
#include "mock/MockVSyncTracker.h"

services/surfaceflinger/tests/unittests/MessageQueueTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
#include <scheduler/interface/ICompositor.h>
2424

25-
#include "FrameTimeline.h"
25+
#include "FrameTimeline/FrameTimeline.h"
2626
#include "Scheduler/MessageQueue.h"
2727
#include "mock/MockVSyncDispatch.h"
2828
#include "utils/Timers.h"

0 commit comments

Comments
 (0)