Skip to content

Commit 2887688

Browse files
author
Steven Moreland
committed
Revert^2 "remove libbinder_ndk_helper_headers"
This reverts commit 1f01c41. Reason for revert: broke NDK variant builds, which wasn't detected due to incremental builds not reflecting sysroot removals. Bug: 357711733 Test: clean builds work Change-Id: I4170325b5d796f990259f6afc4ad7ae0fac01600
1 parent 5a74561 commit 2887688

1 file changed

Lines changed: 4 additions & 16 deletions

File tree

libs/binder/ndk/Android.bp

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ cc_library_headers {
218218
name: "libbinder_headers_platform_shared",
219219
export_include_dirs: ["include_cpp"],
220220
vendor_available: true,
221+
product_available: true,
221222
recovery_available: true,
222223
host_supported: true,
223224
// TODO(b/153609531): remove when no longer needed.
@@ -230,9 +231,9 @@ cc_library_headers {
230231
},
231232
apex_available: [
232233
"//apex_available:platform",
233-
"com.android.media",
234-
"com.android.media.swcodec",
234+
"//apex_available:anyapex",
235235
],
236+
sdk_version: "29", // some APEXes require this, good to test headers against old SDK
236237
min_sdk_version: "29",
237238
}
238239

@@ -246,26 +247,13 @@ ndk_headers {
246247
license: "NOTICE",
247248
}
248249

249-
// TODO(b/160624671): package with the aidl compiler
250-
ndk_headers {
251-
name: "libbinder_ndk_helper_headers",
252-
from: "include_cpp/android",
253-
to: "android",
254-
srcs: [
255-
"include_cpp/android/*.h",
256-
],
257-
license: "NOTICE",
258-
// These are intentionally not C. It's a mistake that they're in the NDK.
259-
// See the bug above.
260-
skip_verification: true,
261-
}
250+
// include_cpp are packaged in development/build/sdk.atree with the AIDL compiler
262251

263252
ndk_library {
264253
name: "libbinder_ndk",
265254
symbol_file: "libbinder_ndk.map.txt",
266255
first_version: "29",
267256
export_header_libs: [
268257
"libbinder_ndk_headers",
269-
"libbinder_ndk_helper_headers",
270258
],
271259
}

0 commit comments

Comments
 (0)