libbinder: stopProcess: directly stop process

Steven Moreland · Steven Moreland · commit 21eb774dcb7d · 2025-01-10T13:53:52.000-08:00
Some threads can fatal abort from this, so go ahead and
stop the process directly. Faster and simpler.

Bug: 388886755
Test: boot
Change-Id: I9fabf092a5199c22ce5952df70c1457e019988a8
diff --git a/libs/binder/IPCThreadState.cpp b/libs/binder/IPCThreadState.cpp
@@ -853,12 +853,8 @@ status_t IPCThreadState::handlePolledCommands()
 
 void IPCThreadState::stopProcess(bool /*immediate*/)
 {
-    //ALOGI("**** STOPPING PROCESS");
-    flushCommands();
-    int fd = mProcess->mDriverFD;
-    mProcess->mDriverFD = -1;
-    close(fd);
-    //kill(getpid(), SIGKILL);
+    ALOGI("IPCThreadState::stopProcess() (deprecated) called. Exiting process.");
+    exit(0);
 }
 
 status_t IPCThreadState::transact(int32_t handle,

Original file line number	Diff line number	Diff line change
`@@ -853,12 +853,8 @@ status_t IPCThreadState::handlePolledCommands()`
`853`	`853`
`854`	`854`	`void IPCThreadState::stopProcess(bool /immediate/)`
`855`	`855`	`{`
`856`		`- //ALOGI("**** STOPPING PROCESS");`
`857`		`- flushCommands();`
`858`		`- int fd = mProcess->mDriverFD;`
`859`		`- mProcess->mDriverFD = -1;`
`860`		`- close(fd);`
`861`		`- //kill(getpid(), SIGKILL);`
	`856`	`+ ALOGI("IPCThreadState::stopProcess() (deprecated) called. Exiting process.");`
	`857`	`+ exit(0);`
`862`	`858`	`}`
`863`	`859`
`864`	`860`	`status_t IPCThreadState::transact(int32_t handle,`