Skip to content

Commit 1732be6

Browse files
committed
GestureConverter: initialize mThreeFingerTapShortcutEnabled
While it looks like this was being consistently initialized by TouchpadInputMapper::reconfigure during real-world usage, in tests it wasn't always being initialized, leading to a ubsan error about it having an invalid value when I was working on adding some new tests: .../GestureConverter.cpp:276:9: runtime error: load of value 190, which is not a valid value for type 'bool' Test: m Test: run tests defined in subsequent CLs Bug: 372571823 Flag: EXEMPT bug fix Change-Id: I44798c35c38c2cb912a995002c6ee325d7bda167
1 parent 94b29e5 commit 1732be6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

services/inputflinger/reader/mapper/gestures/GestureConverter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class GestureConverter {
107107
const bool mEnableNoFocusChange;
108108
bool mEnableSystemGestures{true};
109109

110-
bool mThreeFingerTapShortcutEnabled;
110+
bool mThreeFingerTapShortcutEnabled{false};
111111

112112
std::optional<ui::LogicalDisplayId> mDisplayId;
113113
FloatRect mBoundsInLogicalDisplay{};

0 commit comments

Comments
 (0)