Skip to content

Commit 163c54a

Browse files
Treehugger RobotGerrit Code Review
authored andcommitted
Merge "Skip C-verification of GL headers." into main
2 parents d36a990 + 25ac318 commit 163c54a

2 files changed

Lines changed: 15 additions & 0 deletions

File tree

libs/binder/ndk/Android.bp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,9 @@ ndk_headers {
255255
"include_cpp/android/*.h",
256256
],
257257
license: "NOTICE",
258+
// These are intentionally not C. It's a mistake that they're in the NDK.
259+
// See the bug above.
260+
skip_verification: true,
258261
}
259262

260263
ndk_library {

opengl/Android.bp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ ndk_headers {
3030
to: "",
3131
srcs: ["include/EGL/**/*.h"],
3232
license: "include/EGL/NOTICE",
33+
// eglext.h is not self-contained. Safe to skip C-compat verification
34+
// though since upstream also cares about C compatibility, and the header is
35+
// auto-generated anyway.
36+
skip_verification: true,
3337
}
3438

3539
ndk_headers {
@@ -38,6 +42,10 @@ ndk_headers {
3842
to: "",
3943
srcs: ["include/GLES/**/*.h"],
4044
license: "include/GLES/NOTICE",
45+
// glext.h is not self-contained. Safe to skip C-compat verification
46+
// though since upstream also cares about C compatibility, and the header is
47+
// auto-generated anyway.
48+
skip_verification: true,
4149
}
4250

4351
ndk_headers {
@@ -46,6 +54,10 @@ ndk_headers {
4654
to: "",
4755
srcs: ["include/GLES2/**/*.h"],
4856
license: "include/GLES2/NOTICE",
57+
// gl2ext.h is not self-contained. Safe to skip C-compat verification
58+
// though since upstream also cares about C compatibility, and the header is
59+
// auto-generated anyway.
60+
skip_verification: true,
4961
}
5062

5163
ndk_headers {

0 commit comments

Comments
 (0)