sf: fix misleading log for set thread name

njzhangyifei · njzhangyifei · commit 133684cc7ebb · 2024-02-06T14:49:04.000-08:00
= pthread_setname_np returns 0 on success

Test: build
Bug: 324130008
Change-Id: I5ce1ffa8e72308809cf9e7a7ac44ba61ea8be448
diff --git a/services/surfaceflinger/Scheduler/src/Timer.cpp b/services/surfaceflinger/Scheduler/src/Timer.cpp
@@ -159,7 +159,7 @@ bool Timer::dispatch() {
         ALOGW("Failed to set SCHED_FIFO on dispatch thread");
     }
 
-    if (pthread_setname_np(pthread_self(), "TimerDispatch")) {
+    if (pthread_setname_np(pthread_self(), "TimerDispatch") != 0) {
         ALOGW("Failed to set thread name on dispatch thread");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ bool Timer::dispatch() {`
`159`	`159`	`ALOGW("Failed to set SCHED_FIFO on dispatch thread");`
`160`	`160`	`}`
`161`	`161`
`162`		`- if (pthread_setname_np(pthread_self(), "TimerDispatch")) {`
	`162`	`+ if (pthread_setname_np(pthread_self(), "TimerDispatch") != 0) {`
`163`	`163`	`ALOGW("Failed to set thread name on dispatch thread");`
`164`	`164`	`}`
`165`	`165`