Skip to content

Commit 0e14b50

Browse files
committed
[RE] Change KawaseBlurFilter's temp SkSurface to be unbudgeted
This means it won't count against Skia's internal caching budget. Since this is so short lived I doubt it will affect anything in practice, but it's important to change for clarity for two reasons: 1. The equivalent Graphite function doesn't allow the SkSurface to be budgeted. 2. When `surfaceTwo` is created from `surface`, the result is always unbudgeted. See TODO in `SkSurface_Ganesh::onNewSurface` of external/skia/src/gpu/ganesh/surface/SkSurface_Ganesh.cpp Bug: 293371537 Change-Id: Icd91aaa5b6385458eb92d385241d27c19dd6cce4
1 parent f8680e6 commit 0e14b50

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

libs/renderengine/skia/filters/KawaseBlurFilter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ sk_sp<SkImage> KawaseBlurFilter::generate(GrRecordingContext* context,
111111
constexpr int kSampleCount = 1;
112112
constexpr bool kMipmapped = false;
113113
constexpr SkSurfaceProps* kProps = nullptr;
114-
sk_sp<SkSurface> surface = SkSurfaces::RenderTarget(context, skgpu::Budgeted::kYes, scaledInfo,
114+
sk_sp<SkSurface> surface = SkSurfaces::RenderTarget(context, skgpu::Budgeted::kNo, scaledInfo,
115115
kSampleCount, kTopLeft_GrSurfaceOrigin,
116116
kProps, kMipmapped, input->isProtected());
117117
LOG_ALWAYS_FATAL_IF(!surface, "%s: Failed to create surface for blurring!", __func__);

0 commit comments

Comments
 (0)