skip duplicate check for private segments on upsert (#2472)

bcb37 · web-flow · commit e70ce09fa7d7 · 2025-05-06T15:19:02.000-04:00
diff --git a/backend/packages/Upgrade/src/api/services/SegmentService.ts b/backend/packages/Upgrade/src/api/services/SegmentService.ts
@@ -384,7 +384,9 @@ export class SegmentService {
   }
 
   public async upsertSegment(segment: SegmentInputValidator, logger: UpgradeLogger): Promise<Segment> {
-    await this.checkIsDuplicateSegmentName(segment.name, segment.context, segment.id, logger);
+    if (segment.type !== SEGMENT_TYPE.PRIVATE) {
+      await this.checkIsDuplicateSegmentName(segment.name, segment.context, segment.id, logger);
+    }
     logger.info({ message: `Upsert segment => ${JSON.stringify(segment, undefined, 2)}` });
     return this.addSegmentDataInDB(segment, logger);
   }

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,9 @@ export class SegmentService {`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`public async upsertSegment(segment: SegmentInputValidator, logger: UpgradeLogger): Promise<Segment> {`
`387`		`- await this.checkIsDuplicateSegmentName(segment.name, segment.context, segment.id, logger);`
	`387`	`+ if (segment.type !== SEGMENT_TYPE.PRIVATE) {`
	`388`	`+ await this.checkIsDuplicateSegmentName(segment.name, segment.context, segment.id, logger);`
	`389`	`+ }`
`388`	`390`	logger.info({ message: `Upsert segment => ${JSON.stringify(segment, undefined, 2)}` });
`389`	`391`	`return this.addSegmentDataInDB(segment, logger);`
`390`	`392`	`}`