Skip to content

Commit e365557

Browse files
authored
remove pagination from export queries (#1669)
* remove pagination from export queries * review changes * use read replica for analytics query
1 parent c49ea31 commit e365557

5 files changed

Lines changed: 298 additions & 273 deletions

File tree

backend/packages/Upgrade/src/api/repositories/AnalyticsRepository.ts

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -398,11 +398,7 @@ export class AnalyticsRepository {
398398
return result;
399399
}
400400

401-
public async getCSVDataForSimpleExport(
402-
experimentId: string,
403-
skip: number,
404-
take: number
405-
): Promise<CSVExportDataRow[]> {
401+
public async getCSVDataForSimpleExport(experimentId: string): Promise<CSVExportDataRow[]> {
406402
const individualEnrollmentRepository = getCustomRepository(IndividualEnrollmentRepository, 'export');
407403
return individualEnrollmentRepository
408404
.createQueryBuilder('individualEnrollment')
@@ -439,17 +435,11 @@ export class AnalyticsRepository {
439435
.addGroupBy('"individualEnrollment"."groupId"')
440436
.addGroupBy('condition."conditionCode"')
441437
.orderBy('"individualEnrollment"."userId"', 'ASC')
442-
.offset(skip)
443-
.limit(take)
444438
.where('"individualEnrollment"."experimentId" = :experimentId', { experimentId })
445439
.execute();
446440
}
447441

448-
public async getCSVDataForWithInSubExport(
449-
experimentId: string,
450-
skip: number,
451-
take: number
452-
): Promise<CSVExportDataRow[]> {
442+
public async getCSVDataForWithInSubExport(experimentId: string): Promise<CSVExportDataRow[]> {
453443
const individualEnrollmentRepository = getCustomRepository(IndividualEnrollmentRepository, 'export');
454444
return individualEnrollmentRepository
455445
.createQueryBuilder('individualEnrollment')
@@ -486,8 +476,6 @@ export class AnalyticsRepository {
486476
.addGroupBy('"individualEnrollment"."groupId"')
487477
.addGroupBy('"monitoredPointLogs"."condition"')
488478
.orderBy('"individualEnrollment"."userId"', 'ASC')
489-
.offset(skip)
490-
.limit(take)
491479
.where('"individualEnrollment"."experimentId" = :experimentId', { experimentId })
492480
.execute();
493481
}

0 commit comments

Comments
 (0)