Skip to content

Commit 28c0fa2

Browse files
authored
Merge pull request #248 from bsipocz/MAINT_mixbag_changes
MAINT: mixbag changes
2 parents 2aad8e2 + fddfccf commit 28c0fa2

5 files changed

Lines changed: 22 additions & 24 deletions

File tree

.circleci/config.yml

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,29 @@
11
version: 2.1
22

3-
43
jobs:
4+
55
build-docs:
66
docker:
7-
- image: cimg/python:3.12
7+
- image: cimg/python:3.13-node
8+
89
steps:
910
- checkout
1011

11-
- run:
12-
name: Install Node.js
13-
command: |
14-
curl -fsSL https://deb.nodesource.com/setup_22.x | sudo -E bash -
15-
sudo apt-get install -y nodejs
16-
17-
- run:
18-
name: Install mystmd
19-
command: |
20-
npm install mystmd
21-
2212
- run:
2313
name: Install Python dependencies
2414
command: |
2515
python -m pip install --upgrade pip tox
2616
2717
- run:
28-
name: Build documentation
18+
name: Build HTML rendering of notebooks
2919
no_output_timeout: 60m
3020
environment:
3121
# Ensure this is same as store_artifacts path below
3222
DOCS_PATH: _build/html
3323
command: |
3424
export BASE_URL="/output/job/$CIRCLE_WORKFLOW_JOB_ID/artifacts/0/$DOCS_PATH"
3525
export OMP_NUM_THREADS=1
36-
python -m tox -e py312-buildhtml
37-
26+
python -m tox -e py313-buildhtml
3827
3928
- store_artifacts:
4029
path: _build/html

.mailmap

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
Brigitta Sipőcz <bsipocz@gmail.com>
2+
Brigitta Sipőcz <bsipocz@gmail.com> <b.sipocz@gmail.com>
3+
Jessica Krick <jkrick@caltech.edu>
4+
Tiffany Meshkat <meshkat@ipac.caltech.edu> <meshkat@meshkat.ipac.caltech.edu>
5+
Tiffany Meshkat <meshkat@ipac.caltech.edu> <meshkat@admins-MBP.attlocal.net>
6+
Tiffany Meshkat <meshkat@ipac.caltech.edu> <tiffanymeshkat@gmail.com>
7+
Vandana Desai <vandesai@gmail.com>

myst.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ project:
1414
settings:
1515
output_matplotlib_strings: remove
1616
error_rules:
17+
- rule: reference-target-resolves
18+
severity: error
1719
- rule: link-resolves
1820
severity: ignore
1921
keys:

tox.ini

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ deps =
3333
oldestdeps: sep==1.4.0
3434
oldestdeps: pyvo==1.5.0
3535
oldestdeps: pandas==1.5.2
36+
# Oldest lsdb is not compatible with the versions above, we skip lsdb notebooks for oldestdeps job
37+
# oldestdeps: lsdb==0.6.6
3638

3739
devdeps: astropy>0.0.dev0
3840
devdeps: git+https://github.com/astropy/pyvo.git#egg=pyvo
@@ -67,13 +69,13 @@ commands =
6769
# Make a list of all the tutorials to be reused in multiple filtering commands below
6870
bash -c 'find tutorials -name "*md" | xargs grep kernelspec: | awk -F :kernelspec: "{print \$1}" > all_tutorials'
6971

70-
# Make a list of the tutorials changed, we only need this in CI. Also deal with grep's non-zero exit code.
71-
bash -c 'if [[ $CI == true ]]; then git fetch origin main --depth=1; git diff origin/main --name-only tutorials | grep ".md" || true; fi > changed_tutorials'
72+
# Make a list of the tutorials changed, we only need this in CI. Also deal with grep's non-zero exit code. Deleted files are ignored.
73+
bash -c 'if [[ $CI == true ]]; then git fetch origin main --depth=1; git diff origin/main --name-only --diff-filter=d tutorials | (grep ".md" || true); fi > changed_tutorials'
7274

73-
# We only skip testing untouched tutorials in PRs; in cron and dispatch all should be tested
74-
!buildhtml: bash -c 'if [[ $GITHUB_EVENT_NAME == pull_request && -z "$(grep force_run:all_tests ${GITHUB_EVENT_PATH})" ]]; then cat changed_tutorials; else cat all_tutorials; fi | grep -vf ignore_testing | xargs jupytext --to notebook '
75+
# We only skip testing untouched tutorials in PRs; in cron and dispatch all should be tested. Make sure we don't jupytext non-notebook files.
76+
!buildhtml: bash -c 'if [[ $GITHUB_EVENT_NAME == pull_request && -z "$(grep force_run:all_tests ${GITHUB_EVENT_PATH})" ]]; then grep -f changed_tutorials all_tutorials; else cat all_tutorials; fi | grep -vf ignore_testing | xargs jupytext --to notebook '
7577

76-
!buildhtml: bash -c "echo 'Notebooks ignored (not tested/executed) in this job:\n'; cat ignore_testing"
78+
!buildhtml: bash -c "echo 'Notebooks ignored (not tested/executed) in this job:\n'; cat ignore_testing | sort | uniq"
7779
!buildhtml: pytest --nbval-lax -vv --suppress-no-test-exit-code --durations=10 tutorials
7880

7981
# We don't want to execute in rendering the ones we ignore for testing
@@ -85,7 +87,7 @@ commands =
8587
# sed -i needs a bit of hacky conditional on ubuntu to cover the case of an empty ignore
8688
buildhtml: bash -c 'if [ -s ignore_execute ]; then for name in $(cat ignore_execute | sort| uniq); do if [ -z "$(head -n 20 ${name}| grep execute:)" ]; then sed -i -e "s|kernelspec:|execute:\n skip: true\nkernelspec:|g" ${name}; fi; done;fi'
8789

88-
buildhtml: bash -c "echo 'Notebooks ignored (not tested/executed) in this job:\n'; cat ignore_execute"
90+
buildhtml: bash -c "echo 'Notebooks ignored (not tested/executed) in this job:\n'; cat ignore_execute | sort | uniq"
8991

9092
# Using srtict so we fail with trackbacks and debug mode to have a richer log
9193
# For full build we disable parallel runs to easy server load

tutorials/cosmodc2/cosmoDC2_TAP_access.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ kernelspec:
1010
display_name: Python 3 (ipykernel)
1111
language: python
1212
name: python3
13-
execution:
14-
timeout: 2600
1513
---
1614

1715
# Querying the CosmoDC2 Mock v1 Catalogs

0 commit comments

Comments
 (0)