more cleanups and addressing feedback

Author: kpuriIpac

src/firefly/java/edu/caltech/ipac/firefly/server/query/alert/AlertViewerSearchProcessor.java

@@ -67,13 +67,23 @@ public String fetchData(ServerRequest req) throws DataAccessException {
             }
             final int responseCode = fileInfo.getResponseCode();
             if (responseCode > 305 || responseCode < 200) {
-                final String responseMsg = StringUtils.isEmpty(fileInfo.getResponseCodeMsg())
+                String responseMsg = StringUtils.isEmpty(fileInfo.getResponseCodeMsg())
                         ? "Unknown error"
                         : fileInfo.getResponseCodeMsg();
-                return makeError(source,
-                        "Unable to retrieve the FITS file: " + responseCode + " " + responseMsg);
+
+                String message = switch (responseCode) {
+                    case 400 -> "400 Bad Request: unknown query parameter, or malformed alert ID";
+                    case 401 -> "401 Unauthorized: missing or invalid token";
+                    case 404 -> "404 Not Found: no alert exists for the given ID";
+                    case 415 -> "415 Unsupported Media Type: unrecognised RESPONSEFORMAT value";
+                    case 500 -> "500 Internal Server Error: alert service internal error.";
+                    default -> "Unable to retrieve the FITS file: " + responseCode + " " + responseMsg;
+                };
+
+                return makeError(source, message);
             }
 
+
             FileAnalysisReport report = FileAnalysis.analyze(fileInfo, Details, ANALYZER_ID, Collections.emptyMap());
             return makeSuccess(source, fileInfo, report);
         } catch (Exception e) {
@@ -169,9 +179,9 @@ private static String makeAlertServiceUrl(String alertId) throws DataAccessExcep
             throw new DataAccessException("Missing required property: " + ALERT_SERVICE_BASE_URL_PROP);
         }
         final String joiner = baseUrl.contains("?") ? "&" : "?";
-        return baseUrl + joiner +
-                ALERT_ID + "=" + URLEncoder.encode(alertId, StandardCharsets.UTF_8) + "&" +
-                RESPONSEFORMAT + "=" + FITS_RESPONSE_FORMAT;
+        return String.format("%s%s%s=%s&%s=%s",
+                baseUrl, joiner, ALERT_ID, URLEncoder.encode(alertId, StandardCharsets.UTF_8),
+                RESPONSEFORMAT, FITS_RESPONSE_FORMAT);
     }
 
     private static JSONObject baseResponse(String source, boolean success, String message) {

src/firefly/js/apps/alertviewer/AlertResultView.jsx

@@ -89,12 +89,12 @@ export function AlertResultView() {
     const fallbackTitle = fileName || source || 'Alert Viewer';
     const alertTitleDisplay = id ? (
         <Stack direction='row' spacing={1} alignItems='baseline' sx={{minWidth: 0}}>
-            <Typography level='title-md' sx={{fontFamily: 'monospace'}} color='neutral'>
+            <Typography level='title-md'>
                 Alert ID: {id}
             </Typography>
         </Stack>
     ) : (
-        <Typography level='title-md' sx={{fontFamily: 'monospace'}}>
+        <Typography level='body-md'>
             {fallbackTitle}
         </Typography>
     );