Fix warning related to sizeof() on const char array, the null terminator is not used here so reworked the array to explicitly be 4 elements

CalcProgrammer1 · CalcProgrammer1 · commit cb8ea601cf4a · 2024-07-07T19:29:54.000-05:00
diff --git a/NetworkProtocol.cpp b/NetworkProtocol.cpp
@@ -15,7 +15,7 @@
 /*-----------------------------------------------------*\
 | OpenRGB SDK Magic Value "ORGB"                        |
 \*-----------------------------------------------------*/
-const char * openrgb_sdk_magic = "ORGB";
+const char openrgb_sdk_magic[OPENRGB_SDK_MAGIC_SIZE] = { 'O', 'R', 'G', 'B' };
 
 void InitNetPacketHeader
     (
diff --git a/NetworkProtocol.h b/NetworkProtocol.h
@@ -36,7 +36,8 @@
 /*-----------------------------------------------------*\
 | OpenRGB SDK Magic Value "ORGB"                        |
 \*-----------------------------------------------------*/
-extern const char * openrgb_sdk_magic;
+#define OPENRGB_SDK_MAGIC_SIZE 4
+extern const char openrgb_sdk_magic[OPENRGB_SDK_MAGIC_SIZE];
 
 typedef struct NetPacketHeader
 {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`/-----------------------------------------------------\`
`16`	`16`	`\| OpenRGB SDK Magic Value "ORGB" \|`
`17`	`17`	`\-----------------------------------------------------/`
`18`		`-const char * openrgb_sdk_magic = "ORGB";`
	`18`	`+const char openrgb_sdk_magic[OPENRGB_SDK_MAGIC_SIZE] = { 'O', 'R', 'G', 'B' };`
`19`	`19`
`20`	`20`	`void InitNetPacketHeader`
`21`	`21`	`(`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,8 @@`
`36`	`36`	`/-----------------------------------------------------\`
`37`	`37`	`\| OpenRGB SDK Magic Value "ORGB" \|`
`38`	`38`	`\-----------------------------------------------------/`
`39`		`-extern const char * openrgb_sdk_magic;`
	`39`	`+#define OPENRGB_SDK_MAGIC_SIZE 4`
	`40`	`+extern const char openrgb_sdk_magic[OPENRGB_SDK_MAGIC_SIZE];`
`40`	`41`
`41`	`42`	`typedef struct NetPacketHeader`
`42`	`43`	`{`