Fix warnings in ClevoLightbarController.cpp

CalcProgrammer1 · CalcProgrammer1 · commit 22d908b9a3e5 · 2026-03-02T23:18:40.000-06:00
diff --git a/Controllers/ClevoLightbarController/ClevoLightbarController.cpp b/Controllers/ClevoLightbarController/ClevoLightbarController.cpp
@@ -10,8 +10,9 @@
 |   SPDX-License-Identifier: GPL-2.0-or-later               |
 \*---------------------------------------------------------*/
 
-#include "ClevoLightbarController.h"
 #include <cstring>
+#include "ClevoLightbarController.h"
+#include "StringUtils.h"
 
 ClevoLightbarController::ClevoLightbarController(hid_device* dev_handle, const hid_device_info& info)
 {
@@ -40,10 +41,7 @@ std::string ClevoLightbarController::GetSerialString()
         return("");
     }
 
-    std::wstring return_wstring = serial_string;
-    std::string return_string(return_wstring.begin(), return_wstring.end());
-
-    return(return_string);
+    return(StringUtils::wstring_to_string(serial_string));
 }
 
 std::string ClevoLightbarController::GetFirmwareVersion()

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,9 @@`
`10`	`10`	`\| SPDX-License-Identifier: GPL-2.0-or-later \|`
`11`	`11`	`\---------------------------------------------------------/`
`12`	`12`
`13`		`-#include "ClevoLightbarController.h"`
`14`	`13`	`#include <cstring>`
	`14`	`+#include "ClevoLightbarController.h"`
	`15`	`+#include "StringUtils.h"`
`15`	`16`
`16`	`17`	`ClevoLightbarController::ClevoLightbarController(hid_device* dev_handle, const hid_device_info& info)`
`17`	`18`	`{`
`@@ -40,10 +41,7 @@ std::string ClevoLightbarController::GetSerialString()`
`40`	`41`	`return("");`
`41`	`42`	`}`
`42`	`43`
`43`		`- std::wstring return_wstring = serial_string;`
`44`		`- std::string return_string(return_wstring.begin(), return_wstring.end());`
`45`		`-`
`46`		`- return(return_string);`
	`44`	`+ return(StringUtils::wstring_to_string(serial_string));`
`47`	`45`	`}`
`48`	`46`
`49`	`47`	`std::string ClevoLightbarController::GetFirmwareVersion()`