From ce2aa241a51fae8102932f4adac61be973eccd06 Mon Sep 17 00:00:00 2001 From: Affan Ziya Date: Mon, 2 Nov 2026 21:10:40 +0530 Subject: [PATCH] plugins types BUGFIX ipv4-prefix canonical print buffer overflow --- src/plugins_types/ipv4_address_prefix.c | 2 +- tests/utests/types/inet_types.c | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/plugins_types/ipv4_address_prefix.c b/src/plugins_types/ipv4_address_prefix.c index bc66fd2da..350b1a3ae 100644 --- a/src/plugins_types/ipv4_address_prefix.c +++ b/src/plugins_types/ipv4_address_prefix.c @@ -265,7 +265,7 @@ lyplg_type_print_ipv4_address_prefix(const struct ly_ctx *ctx, const struct lyd_ /* generate canonical value if not already */ if (!value->_canonical) { /* IPv4 mask + '/' + prefix */ - ret = malloc(INET_ADDRSTRLEN + 3); + ret = malloc(INET_ADDRSTRLEN + 4); LY_CHECK_RET(!ret, NULL); /* convert back to string */ diff --git a/tests/utests/types/inet_types.c b/tests/utests/types/inet_types.c index bbe3c05e7..d7327d45a 100644 --- a/tests/utests/types/inet_types.c +++ b/tests/utests/types/inet_types.c @@ -134,6 +134,16 @@ test_data_xml(void **state) TEST_SUCCESS_XML("a", "l6", "0.1.58.4/32", STRING, "0.1.58.4/32"); TEST_SUCCESS_XML("a", "l6", "12.1.58.4/8", STRING, "12.0.0.0/8"); + /* store-only skips the pattern, so a 3-digit prefix reaches the printer */ + { + struct lyd_node *tree; + const char *data = "255.255.255.255/255"; + + CHECK_PARSE_LYD_PARAM(data, LYD_XML, LYD_PARSE_ONLY | LYD_PARSE_STORE_ONLY, LYD_VALIDATE_PRESENT, LY_SUCCESS, tree); + CHECK_LYD_STRING_PARAM(tree, "255.255.255.255/255\n", LYD_XML, 0); + lyd_free_all(tree); + } + /* ipv6-prefix */ TEST_SUCCESS_XML("a", "l7", "::C:D:E:f:a/112", STRING, "::c:d:e:f:0/112"); TEST_SUCCESS_XML("a", "l7", "::C:D:E:f:a/110", STRING, "::c:d:e:c:0/110");