Gui2: add missing tests (#167)

* gui2: add missing tests
* fixing the detected error
* fixed bug in test

Author: nimrof

.github/workflows/dotnet.yml

@@ -42,6 +42,10 @@ jobs:
     - name: Test
       run: |
           dotnet test --no-build --verbosity normal Tests\bin\${{ matrix.configuration }}\${{ matrix.dotnet }}*\tests.dll
+    - name: GUITest
+      if: matrix.dotnet == 'net8'
+      run: |
+          dotnet test --no-build --verbosity normal GUITests\bin\${{ matrix.configuration }}\${{ matrix.dotnet }}*\GUITests.dll
     - name: Upload Artifact
       uses: actions/upload-artifact@v4
       with:

EDSEditorGUI2/ViewModels/DeviceOD.cs

@@ -40,7 +40,7 @@ public void AddIndex(int index, string name, LibCanOpen.OdObject.Types.ObjectTyp
         var newObj = new OdObject
         {
             Name = name,
-            Type = type
+            ObjectType = type
         };
 
         // create OD entry

EDSEditorGUI2/ViewModels/OdObject.cs

@@ -22,7 +22,7 @@ public partial class OdObject : ObservableObject
         string _description = string.Empty;
 
         [ObservableProperty]
-        LibCanOpen.OdObject.Types.ObjectType _type;
+        LibCanOpen.OdObject.Types.ObjectType _objectType;
 
         [ObservableProperty]
         string _countLabel = string.Empty;
@@ -41,13 +41,13 @@ public partial class OdObject : ObservableObject
         /// </summary>
         public OdSubObject? AddSubEntry(KeyValuePair<string, OdSubObject> selected)
         {
-            if (Type == LibCanOpen.OdObject.Types.ObjectType.Var)
+            if (ObjectType == LibCanOpen.OdObject.Types.ObjectType.Var)
                 return null;
 
             OdSubObject newOd;
 
             //Do we need the type check??
-            if ((SubObjects.Count == 0) && ((Type == LibCanOpen.OdObject.Types.ObjectType.Array) || (Type == LibCanOpen.OdObject.Types.ObjectType.Record)))
+            if ((SubObjects.Count == 0) && ((ObjectType == LibCanOpen.OdObject.Types.ObjectType.Array) || (ObjectType == LibCanOpen.OdObject.Types.ObjectType.Record)))
             {
                 SubObjects.Add(new KeyValuePair<string, OdSubObject>("0", new OdSubObject
                 {
@@ -125,7 +125,7 @@ public partial class OdObject : ObservableObject
         /// <returns>true on successfull removal</returns>
         public bool RemoveSubEntry(KeyValuePair<string, OdSubObject> subObjectToRemove, bool renumber)
         {
-            if (Type == LibCanOpen.OdObject.Types.ObjectType.Array || Type == LibCanOpen.OdObject.Types.ObjectType.Record)
+            if (ObjectType == LibCanOpen.OdObject.Types.ObjectType.Array || ObjectType == LibCanOpen.OdObject.Types.ObjectType.Record)
             {
                 UInt16 maxSubIndex = SubObjects[0].Value.DefaultValue.ToInteger();
                 UInt16 lastSubIndex = SubObjects.Last().Key.ToInteger();

GUITests/MappingTests.cs

@@ -0,0 +1,16 @@
+using EDSEditorGUI2.Mapper;
+using LibCanOpen;
+
+namespace GUITests
+{
+    public class MappingTests
+    {
+        [Fact]
+        public void MappingFromProtobuffer()
+        {
+            // testing for exception in the mapping assert.
+            var sut = new CanOpenDevice();
+            ProtobufferViewModelMapper.MapFromProtobuffer(sut);
+        }
+    }
+}

GUITests/ViewModels_OdObjects.cs

@@ -41,7 +41,7 @@ public ViewModels_OdObjects()
         public void AddSubEntry_VarType()
         {
             sut = new OdObject();
-            sut.Type = LibCanOpen.OdObject.Types.ObjectType.Var;
+            sut.ObjectType = LibCanOpen.OdObject.Types.ObjectType.Var;
             sut.SubObjects.Add(new KeyValuePair<string, OdSubObject>("0", new OdSubObject
             {
                 Name = "variableTest",
@@ -58,7 +58,7 @@ public void AddSubEntry_VarType()
         [Fact]
         public void AddSubEntry_RecordType()
         {
-            sut.Type = LibCanOpen.OdObject.Types.ObjectType.Record;
+            sut.ObjectType = LibCanOpen.OdObject.Types.ObjectType.Record;
             sut.AddSubEntry(sut.SubObjects[1]);
             Assert.Equal(4, sut.SubObjects.Count);
             Assert.Equal("0x03", sut.SubObjects[0].Value.DefaultValue);
@@ -70,7 +70,7 @@ public void AddSubEntry_RecordType()
         public void RemoveSubEntry_VarType(bool renumber)
         {
             sut = new OdObject();
-            sut.Type = LibCanOpen.OdObject.Types.ObjectType.Var;
+            sut.ObjectType = LibCanOpen.OdObject.Types.ObjectType.Var;
             sut.SubObjects.Add(new KeyValuePair<string, OdSubObject>("0x01", new OdSubObject
             {
                 Name = "variableTest",
@@ -88,7 +88,7 @@ public void RemoveSubEntry_VarType(bool renumber)
         public void RemoveSubEntry_RecordType()
         {
             sut = new OdObject();
-            sut.Type = LibCanOpen.OdObject.Types.ObjectType.Record;
+            sut.ObjectType = LibCanOpen.OdObject.Types.ObjectType.Record;
             sut.SubObjects.Add(new KeyValuePair<string, OdSubObject>("0x00", new OdSubObject
             {
                 Name = "variableTest0",
@@ -118,7 +118,7 @@ public void RemoveSubEntry_RecordType()
             }));
 
             var result = sut.RemoveSubEntry(sut.SubObjects[1], false);
-            Assert.False(result);
+            Assert.True(result);
         }
     }
 }