Skip to content

Commit 085811f

Browse files
bieluclaude
andcommitted
fix: always serialize SQS fifoQueue
The AsyncAPI SQS binding schema requires fifoQueue, but it was omitted when false. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 parent 70b3885 commit 085811f

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎src/ByteBard.AsyncAPI.Bindings/Sqs/Queue.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public void Serialize(IAsyncApiWriter writer)
7474

7575
writer.WriteStartObject();
7676
writer.WriteRequiredProperty("name", this.Name);
77-
writer.WriteOptionalProperty("fifoQueue", this.FifoQueue);
77+
writer.WriteRequiredProperty("fifoQueue", this.FifoQueue);
7878
writer.WriteOptionalProperty("deduplicationScope", this.DeduplicationScope?.GetDisplayName());
7979
writer.WriteOptionalProperty("fifoThroughputLimit", this.FifoThroughputLimit?.GetDisplayName());
8080
writer.WriteOptionalProperty("deliveryDelay", this.DeliveryDelay);

‎test/ByteBard.AsyncAPI.Tests/Bindings/Sqs/SqsBindings_should.cs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ public void V2_SqsChannelBinding_WithFilledObject_SerializesAndDeserializes()
7171
queueXPropertyName: queueXPropertyValue
7272
deadLetterQueue:
7373
name: myQueue_error
74+
fifoQueue: false
7475
deliveryDelay: 0
7576
visibilityTimeout: 0
7677
receiveMessageWaitTime: 0
@@ -276,6 +277,7 @@ public void V2_SqsOperationBinding_WithFilledObject_SerializesAndDeserializes()
276277
sqs:
277278
queues:
278279
- name: myQueue
280+
fifoQueue: false
279281
deliveryDelay: 30
280282
visibilityTimeout: 60
281283
receiveMessageWaitTime: 0
@@ -312,6 +314,7 @@ public void V2_SqsOperationBinding_WithFilledObject_SerializesAndDeserializes()
312314
x-queueExtension:
313315
queueXPropertyName: queueXPropertyValue
314316
- name: myQueue_error
317+
fifoQueue: false
315318
deliveryDelay: 0
316319
visibilityTimeout: 0
317320
receiveMessageWaitTime: 0

0 commit comments

Comments
 (0)