Skip to content

Commit 26fcc18

Browse files
committed
Close #31, some improvements
1 parent 48576f6 commit 26fcc18

12 files changed

Lines changed: 257 additions & 86 deletions

File tree

Source/NETworkManager/Models/Settings/CommandLineManager.cs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,29 +54,26 @@ public static void Parse()
5454
}
5555
else
5656
{
57-
AddToWrongParameter(parameters[i]);
58-
59-
Current.Help = true;
57+
WrongParameterDetected(parameters);
58+
return;
6059
}
6160
}
6261
else
6362
{
6463
// Ignore the first parameter because it's the path of the .exe
6564
if (i != 0)
6665
{
67-
AddToWrongParameter(parameters[i]);
68-
Current.Help = true;
66+
WrongParameterDetected(parameters);
67+
return;
6968
}
7069
}
7170
}
7271
}
7372

74-
private static void AddToWrongParameter(string parameter)
73+
private static void WrongParameterDetected(string[] parameters)
7574
{
76-
if (!string.IsNullOrEmpty(Current.WrongParameter))
77-
Current.WrongParameter += Environment.NewLine;
78-
79-
Current.WrongParameter += parameter;
75+
Current.WrongParameter = string.Join(" ", parameters);
76+
Current.Help = true;
8077
}
8178
}
8279
}

Source/NETworkManager/Models/Settings/SettingsInfo.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -718,6 +718,20 @@ public bool PortScanner_ResolveHostnamePreferIPv4
718718
SettingsChanged = true;
719719
}
720720
}
721+
722+
private bool _portScanner_ExpandStatistics = true;
723+
public bool PortScanner_ExpandStatistics
724+
{
725+
get { return _portScanner_ExpandStatistics; }
726+
set
727+
{
728+
if (value == _portScanner_ExpandStatistics)
729+
return;
730+
731+
_portScanner_ExpandStatistics = value;
732+
SettingsChanged = true;
733+
}
734+
}
721735
#endregion
722736

723737
#region WakeOnLAN

Source/NETworkManager/Resources/Localization/Resources.de-DE.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
<system:String x:Key="String_Header_Transparency">Transparenz</system:String>
6565
<system:String x:Key="String_Header_WakeOnLAN">Wake on LAN</system:String>
6666
<system:String x:Key="String_Header_CommandLineArguments">Befehlszeilenargumente</system:String>
67-
<system:String x:Key="String_Header_WrongParameter">Falscher Parameter</system:String>
6867

6968
<!-- Normal strings -->
7069
<system:String x:Key="String_ProductName">NETworkManager</system:String>
@@ -224,7 +223,8 @@
224223
<system:String x:Key="String_TheApplicationCanBeStartedWithoutParameters">Die Anwendung kann ohne Parameter gestartet werden!</system:String>
225224
<system:String x:Key="String_TheFollwingParametersCanNotBeProcesses">Die folgenden Parameter können nicht verarbeitet werden:</system:String>
226225
<system:String x:Key="String_TheFollowingParametersAreAvailable">Folgende Parameter stehen zur Verfügung:</system:String>
227-
226+
<system:String x:Key="String_Open">Offen</system:String>
227+
228228
<!-- Buttons -->
229229
<system:String x:Key="String_Button_Change">Wechseln</system:String>
230230
<system:String x:Key="String_Button_Default">Standard</system:String>

Source/NETworkManager/Resources/Localization/Resources.en-US.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
<system:String x:Key="String_Header_Transparency">Transparency</system:String>
6666
<system:String x:Key="String_Header_WakeOnLAN">Wake on LAN</system:String>
6767
<system:String x:Key="String_Header_CommandLineArguments">Command Line Arguments</system:String>
68-
<system:String x:Key="String_Header_WrongParameter">Wrong parameter</system:String>
6968

7069
<!-- Normal strings -->
7170
<system:String x:Key="String_ProductName">NETworkManager</system:String>
@@ -226,6 +225,7 @@
226225
<system:String x:Key="String_TheApplicationCanBeStartedWithoutParameters">The application can be started without parameters!</system:String>
227226
<system:String x:Key="String_TheFollwingParametersCanNotBeProcesses">The following parameters can not be processed:</system:String>
228227
<system:String x:Key="String_TheFollowingParametersAreAvailable">The following parameters are available:</system:String>
228+
<system:String x:Key="String_Open">Open</system:String>
229229

230230
<!-- Buttons -->
231231
<system:String x:Key="String_Button_Change">Change</system:String>

Source/NETworkManager/ViewModels/Applications/IPScannerViewModel.cs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -361,9 +361,7 @@ private void StopScan()
361361
}
362362

363363
private void ScanFinished()
364-
{
365-
IsScanRunning = false;
366-
364+
{
367365
// Stop timer and stopwatch
368366
stopwatch.Stop();
369367
dispatcherTimer.Stop();
@@ -372,6 +370,9 @@ private void ScanFinished()
372370
EndTime = DateTime.Now;
373371

374372
stopwatch.Reset();
373+
374+
CancelScan = false;
375+
IsScanRunning = false;
375376
}
376377

377378
public void OnShutdown()
@@ -406,12 +407,10 @@ private void IpScanner_ProgressChanged(object sender, ProgressChangedArgs e)
406407

407408
private void UserHasCanceled(object sender, EventArgs e)
408409
{
409-
CancelScan = false;
410-
411-
ScanFinished();
412-
413410
StatusMessage = Application.Current.Resources["String_CanceledByUser"] as string;
414411
DisplayStatusMessage = true;
412+
413+
ScanFinished();
415414
}
416415

417416
private void DispatcherTimer_Tick(object sender, EventArgs e)

0 commit comments

Comments
 (0)