Skip to content

Commit 081bf1a

Browse files
committed
Ping statistics improved, expander added
1 parent 1659332 commit 081bf1a

6 files changed

Lines changed: 47 additions & 14 deletions

File tree

Source/NETworkManager/Models/Settings/CommandLineManager.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,6 @@ public static void Parse()
5656
Current.Help = true;
5757
}
5858
}
59-
else
60-
{
61-
Current.Help = true;
62-
}
6359
}
6460
}
6561

Source/NETworkManager/Models/Settings/SettingsInfo.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,20 @@ public int Ping_ExceptionCancelCount
502502
SettingsChanged = true;
503503
}
504504
}
505+
506+
private bool _ping_ExpandStatistics = true;
507+
public bool Ping_ExpandStatistics
508+
{
509+
get { return _ping_ExpandStatistics; }
510+
set
511+
{
512+
if (value == _ping_ExpandStatistics)
513+
return;
514+
515+
_ping_ExpandStatistics = value;
516+
SettingsChanged = true;
517+
}
518+
}
505519
#endregion
506520

507521
#region Traceroute

Source/NETworkManager/Models/Settings/SettingsManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,6 @@ public static void Reset()
202202

203203
ForceRestart = true;
204204
}
205-
#endregion
205+
#endregion
206206
}
207207
}

Source/NETworkManager/Resources/Styles/ExpanderStyles.xaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@
1414
BorderThickness="{TemplateBinding BorderThickness}">
1515
<Grid Background="Transparent" SnapsToDevicePixels="False">
1616
<Grid.ColumnDefinitions>
17-
<ColumnDefinition Width="Auto" />
1817
<ColumnDefinition Width="*" />
18+
<ColumnDefinition Width="Auto" />
1919
</Grid.ColumnDefinitions>
20-
<Rectangle x:Name="Test" Width="16" Height="16" Fill="{DynamicResource GrayBrush3}">
20+
<Rectangle Grid.Column="1" x:Name="Chevron" Width="16" Height="16" Fill="{DynamicResource GrayBrush3}" VerticalAlignment="Center">
2121
<Rectangle.OpacityMask>
2222
<VisualBrush Stretch="Uniform" Visual="{IconPacks:PackIconMaterial Kind=ChevronDown}" />
2323
</Rectangle.OpacityMask>
2424
</Rectangle>
25-
<Controls:ContentControlEx Grid.Column="1"
26-
Margin="4 0 0 0"
25+
<Controls:ContentControlEx Grid.Column="0"
26+
Margin="0"
2727
HorizontalAlignment="Stretch"
2828
Padding="{TemplateBinding Padding}"
2929
HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
@@ -39,14 +39,14 @@
3939
</Border>
4040
<ControlTemplate.Triggers>
4141
<Trigger Property="IsChecked" Value="True">
42-
<Setter TargetName="Test" Property="OpacityMask">
42+
<Setter TargetName="Chevron" Property="OpacityMask">
4343
<Setter.Value>
4444
<VisualBrush Stretch="Uniform" Visual="{IconPacks:PackIconMaterial Kind=ChevronUp}" />
4545
</Setter.Value>
4646
</Setter>
4747
</Trigger>
4848
<Trigger Property="IsMouseOver" Value="True">
49-
<Setter TargetName="Test" Property="Fill" Value="{DynamicResource GrayBrush5}"/>
49+
<Setter TargetName="Chevron" Property="Fill" Value="{DynamicResource GrayBrush5}"/>
5050
</Trigger>
5151
</ControlTemplate.Triggers>
5252
</ControlTemplate>

Source/NETworkManager/ViewModels/Applications/PingViewModel.cs

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,23 @@ public DateTime? EndTime
227227
OnPropertyChanged();
228228
}
229229
}
230+
231+
private bool _expandStatistics;
232+
public bool ExpandStatistics
233+
{
234+
get { return _expandStatistics; }
235+
set
236+
{
237+
if (value == _expandStatistics)
238+
return;
239+
240+
if (!_isLoading)
241+
SettingsManager.Current.Ping_ExpandStatistics = value;
242+
243+
_expandStatistics = value;
244+
OnPropertyChanged();
245+
}
246+
}
230247
#endregion
231248

232249
#region Contructor
@@ -250,6 +267,8 @@ private void LoadSettings()
250267
{
251268
if (SettingsManager.Current.Ping_HostnameOrIPAddressHistory != null)
252269
HostnameOrIPAddressHistory = new List<string>(SettingsManager.Current.Ping_HostnameOrIPAddressHistory);
270+
271+
ExpandStatistics = SettingsManager.Current.Ping_ExpandStatistics;
253272
}
254273
#endregion
255274

Source/NETworkManager/Views/Applications/PingView.xaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,12 @@
133133
<DataGridTextColumn Header="{DynamicResource String_Status}" Binding="{Binding Status, Converter={StaticResource IPStatusToStringConverter}}" MinWidth="150"/>
134134
</Control:ScrollingDataGrid.Columns>
135135
</Control:ScrollingDataGrid>
136-
<StackPanel Grid.Row="4">
137-
<TextBlock Text="{DynamicResource String_Header_Statistics}" Style="{StaticResource HeaderTextBlock}" />
138-
<Grid>
136+
<Expander Grid.Row="4" IsExpanded="{Binding ExpandStatistics}" Style="{StaticResource DefaultExpander}">
137+
<Expander.Header>
138+
<TextBlock Text="{DynamicResource String_Header_Statistics}" Style="{StaticResource HeaderTextBlock}" Margin="0" />
139+
</Expander.Header>
140+
<StackPanel FlowDirection="LeftToRight">
141+
<Grid Margin="0,10,0,0">
139142
<Grid.ColumnDefinitions>
140143
<ColumnDefinition Width="1*" />
141144
<ColumnDefinition Width="1*" />
@@ -194,5 +197,6 @@
194197
<TextBox Grid.Column="7" Grid.Row="4" Text="{Binding MaximumTime, StringFormat={}{0} ms}" />
195198
</Grid>
196199
</StackPanel>
200+
</Expander>
197201
</Grid>
198202
</UserControl>

0 commit comments

Comments
 (0)