[FIX] Comments added

Author: ricardosp4

src/blosc2/ndarray.py

@@ -3709,6 +3709,10 @@ def matmul(x1: NDArray, x2: NDArray, **kwargs: Any) -> NDArray:
     if np.isscalar(x1) or np.isscalar(x2):
         raise ValueError("Arguments can't be scalars.")
 
+    # Validate arguments are dimension 1 or 2
+    if x1.ndim > 2 or x2.ndim > 2:
+        raise ValueError("Multiplication of arrays with dimension greater than 2 is not supported yet.")
+
     # Promote 1D arrays to 2D if necessary
     x1_is_vector = False
     x2_is_vector = False
@@ -3729,7 +3733,7 @@ def matmul(x1: NDArray, x2: NDArray, **kwargs: Any) -> NDArray:
     p1, q1 = x1.chunks[-2:]
     q2 = x2.chunks[-1]
 
-    result = blosc2.zeros((n, m), dtype=x1.dtype)
+    result = blosc2.zeros((n, m), dtype=np.result_type(x1, x2), **kwargs)
 
     for row in range(0, n, p1):
         row_end = (row + p1) if (row + p1) < n else n

tests/ndarray/test_matmul.py

@@ -1,5 +1,6 @@
-import pytest
 import numpy as np
+import pytest
+
 import blosc2
 
 
@@ -19,7 +20,8 @@
     ],
 )
 @pytest.mark.parametrize(
-    "dtype", [np.float32, np.float64, np.complex64, np.complex128],
+    "dtype",
+    [np.float32, np.float64, np.complex64, np.complex128],
 )
 def test_matmul(ashape, achunks, ablocks, bshape, bchunks, bblocks, dtype):
     a = blosc2.linspace(0, 10, dtype=dtype, shape=ashape, chunks=achunks, blocks=ablocks)
@@ -60,17 +62,20 @@ def test_matmul_shapes(ashape, achunks, ablocks, bshape, bchunks, bblocks):
         blosc2.matmul(b, a)
 
 
-@pytest.mark.parametrize("scalar", [
-    5,                      # int
-    5.3,                    # float
-    1 + 2j,                 # complex
-    np.int32(5),            # NumPy int32
-    np.int64(5),            # NumPy int64
-    np.float32(5.3),        # NumPy float32
-    np.float64(5.3),        # NumPy float64
-    np.complex64(1 + 2j),   # NumPy complex64
-    np.complex128(1 + 2j),  # NumPy complex128
-])
+@pytest.mark.parametrize(
+    "scalar",
+    [
+        5,  # int
+        5.3,  # float
+        1 + 2j,  # complex
+        np.int32(5),  # NumPy int32
+        np.int64(5),  # NumPy int64
+        np.float32(5.3),  # NumPy float32
+        np.float64(5.3),  # NumPy float64
+        np.complex64(1 + 2j),  # NumPy complex64
+        np.complex128(1 + 2j),  # NumPy complex128
+    ],
+)
 def test_matmul_scalars(scalar):
     vector = blosc2.asarray(np.array([1, 2, 3]))
 
@@ -82,3 +87,29 @@ def test_matmul_scalars(scalar):
 
     with pytest.raises(ValueError):
         blosc2.matmul(scalar, scalar)
+
+
+@pytest.mark.parametrize(
+    "ashape",
+    [
+        (12, 10, 10),
+        (7, 5, 5),
+        (3, 3, 3),
+    ],
+)
+@pytest.mark.parametrize(
+    "bshape",
+    [
+        (10, 10, 10, 11),
+        (3, 2, 9),
+    ],
+)
+def test_matmul_dims(ashape, bshape):
+    a = blosc2.linspace(0, 10, shape=ashape)
+    b = blosc2.linspace(0, 1, shape=bshape)
+
+    with pytest.raises(ValueError):
+        blosc2.matmul(a, b)
+
+    with pytest.raises(ValueError):
+        blosc2.matmul(b, a)