From 399b57cae7d26a95d28785e93018bfd110ec1568 Mon Sep 17 00:00:00 2001 From: BlackSpirits Date: Sun, 13 Sep 2026 18:05:08 +0200 Subject: [PATCH 1/2] Tests: stop suppressing accessibility dispatcher failures --- tests/UI/Logic/AccessibleNamesTests.cs | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/UI/Logic/AccessibleNamesTests.cs b/tests/UI/Logic/AccessibleNamesTests.cs index 387887d73f..9a72c5b62b 100644 --- a/tests/UI/Logic/AccessibleNamesTests.cs +++ b/tests/UI/Logic/AccessibleNamesTests.cs @@ -104,22 +104,14 @@ public void EveryInputInEveryWindow_HasAnAccessibleName() } /// - /// Runs pending dispatcher jobs, ignoring what they throw. Some view models probe media - /// on a background thread from Loaded and post a message box back (Video OCR: "unable - /// to read video"); when that post lands after the window is closed, showing the box - /// throws "Cannot show a window with a closed owner" - a timing artifact of opening - /// windows without files, not an accessibility finding. + /// Runs pending dispatcher jobs. Unexpected dispatcher failures must fail the test; + /// the Video OCR closed-owner race that previously required suppression is now fixed + /// at the source by checking whether its window is already closing before showing the + /// message box. /// private static void DrainJobs() { - try - { - Dispatcher.UIThread.RunJobs(); - } - catch (Exception) - { - // Ignored - see summary. - } + Dispatcher.UIThread.RunJobs(); } private static string Describe(Control control) From 900776650bfac2c9e8b7c14acb1b0ac75adca5bd Mon Sep 17 00:00:00 2001 From: BlackSpirits Date: Sun, 13 Sep 2026 18:07:19 +0200 Subject: [PATCH 2/2] Tests: document upstream Video OCR race fix --- tests/UI/Logic/AccessibleNamesTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/UI/Logic/AccessibleNamesTests.cs b/tests/UI/Logic/AccessibleNamesTests.cs index 9a72c5b62b..ead0692351 100644 --- a/tests/UI/Logic/AccessibleNamesTests.cs +++ b/tests/UI/Logic/AccessibleNamesTests.cs @@ -107,7 +107,7 @@ public void EveryInputInEveryWindow_HasAnAccessibleName() /// Runs pending dispatcher jobs. Unexpected dispatcher failures must fail the test; /// the Video OCR closed-owner race that previously required suppression is now fixed /// at the source by checking whether its window is already closing before showing the - /// message box. + /// message box (upstream 6840e797). /// private static void DrainJobs() {