query param improvement for payload delete and point search endpoints hkulekci#8

Author: hkulekci

src/Endpoints/Collections/Points.php

@@ -31,12 +31,12 @@ public function payload(): Payload
     /**
      * @throws InvalidArgumentException
      */
-    public function search(SearchRequest $searchParams): Response
+    public function search(SearchRequest $searchParams, array $queryParams = []): Response
     {
         return $this->client->execute(
             $this->createRequest(
                 'POST',
-                'collections/' . $this->collectionName . '/points/search',
+                'collections/' . $this->collectionName . '/points/search' . $this->queryBuild($queryParams),
                 $searchParams->toArray()
             )
         );

src/Endpoints/Collections/Points/Payload.php

@@ -40,7 +40,7 @@ public function clear(array $points): Response
      * @return Response
      * @throws InvalidArgumentException
      */
-    public function delete(array $points, array $keys, Filter $filter = null): Response
+    public function delete(array $points, array $keys, Filter $filter = null, array $queryParams = []): Response
     {
         $data = [
             'points' => $points,
@@ -53,7 +53,7 @@ public function delete(array $points, array $keys, Filter $filter = null): Respo
         return $this->client->execute(
             $this->createRequest(
                 'POST',
-                '/collections/' . $this->getCollectionName() . '/points/payload/delete',
+                '/collections/' . $this->getCollectionName() . '/points/payload/delete' . $this->queryBuild($queryParams),
                 $data
             )
         );
@@ -62,12 +62,12 @@ public function delete(array $points, array $keys, Filter $filter = null): Respo
     /**
      * @throws InvalidArgumentException
      */
-    public function set(array $points, array $payload, array $params = []): Response
+    public function set(array $points, array $payload, array $queryParams = []): Response
     {
         return $this->client->execute(
             $this->createRequest(
                 'POST',
-                '/collections/' . $this->getCollectionName() . '/points/payload' . $this->queryBuild($params),
+                '/collections/' . $this->getCollectionName() . '/points/payload' . $this->queryBuild($queryParams),
                 [
                     'payload' => $payload,
                     'points' => $points,

tests/Integration/Endpoints/Collections/ClusterTest.php

@@ -43,7 +43,7 @@ public function testClusterUpdate(): void
         $response = $cluster->update([
             "move_shard" => [
                 "shard_id" => 0,
-                "to_peer_id" => 0,
+                "to_peer_id" => 1,
                 "from_peer_id" => 0
             ]
         ]);

tests/Integration/Endpoints/Collections/Points/PayloadTest.php

@@ -109,6 +109,28 @@ public function testDeletePayloadForPoint(array $pointsArray): void
         $this->assertEmpty($response['result']['payload']);
     }
 
+    /**
+     * @throws InvalidArgumentException
+     * @dataProvider basicPointDataProvider
+     */
+    public function testDeletePayloadForPointWithQueryParams(array $pointsArray): void
+    {
+        $collections = new Collections($this->client);
+
+        $response = $collections->setCollectionName('sample-collection')->create(self::sampleCollectionOption());
+        $this->assertEquals('ok', $response['status'], 'Collection Could Not Created!');
+        $points = $collections->setCollectionName('sample-collection')->points();
+        $points->upsert(PointsStruct::createFromArray($pointsArray));
+
+        $payload = $collections->setCollectionName('sample-collection')->points()->payload();
+        $payload->delete([2], ['image'], null, ['wait' => 'true', 'ordering' => 'strong']);
+
+        $response = $points->id(2);
+        $this->assertArrayHasKey('result', $response);
+        $this->assertArrayHasKey('payload', $response['result']);
+        $this->assertEmpty($response['result']['payload']);
+    }
+
     /**
      * @throws InvalidArgumentException
      * @dataProvider basicPointDataProvider

tests/Integration/Endpoints/Collections/SearchTest.php

@@ -83,6 +83,31 @@ public function testSearchPoint(VectorStruct $vector): void
         $this->assertCount(1, $response['result']);
     }
 
+
+    /**
+     * @dataProvider searchQueryProvider
+     */
+    public function testSearchPointWithQueryParams(VectorStruct $vector): void
+    {
+        $searchRequest = (new SearchRequest($vector))
+            ->setLimit(3)
+            ->setFilter(
+                (new Filter())->addMust(
+                    new MatchString('image', 'sample image')
+                )
+            )
+            ->setParams([
+                'hnsw_ef' => 128,
+                'exact' => false,
+            ]);
+
+        $response = $this->getCollections('sample-collection')
+            ->points()->search($searchRequest, ['timeout' => 1, 'consistency' => 'all']);
+
+        $this->assertEquals('ok', $response['status']);
+        $this->assertCount(1, $response['result']);
+    }
+
     /**
      * @dataProvider searchQueryProvider
      */