WalConfig initialized and HnswTests improved

Author: hkulekci

src/Models/Request/CollectionConfig/HnswConfig.php

@@ -22,7 +22,7 @@ class HnswConfig implements RequestModel
 
     public function setM(?int $m): HnswConfig
     {
-        if ($this->efConstruct < 0) {
+        if ($m < 0) {
             throw new InvalidArgumentException('m should be bigger than 0');
         }
         $this->m = $m;

src/Models/Request/CollectionConfig/WalConfig.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * WalConfig
+ *
+ * @since     Dec 2023
+ * @author    Haydar KULEKCI <haydarkulekci@gmail.com>
+ */
+
+namespace Qdrant\Models\Request\CollectionConfig;
+
+use Qdrant\Exception\InvalidArgumentException;
+use Qdrant\Models\Request\RequestModel;
+
+class WalConfig implements RequestModel
+{
+    protected ?int $walCapacityMb = null;
+    protected ?int $walSegmentsAhead = null;
+
+    public function setWalCapacityMb(?int $walCapacityMb): WalConfig
+    {
+        if ($walCapacityMb < 1) {
+            throw new InvalidArgumentException('wal_capacity_mb should be bigger than 1');
+        }
+        $this->walCapacityMb = $walCapacityMb;
+
+        return $this;
+    }
+
+    public function setWalSegmentsAhead(?int $walSegmentsAhead): WalConfig
+    {
+        if ($walSegmentsAhead < 0) {
+            throw new InvalidArgumentException('wal_segments_ahead should be bigger than 0');
+        }
+        $this->walSegmentsAhead = $walSegmentsAhead;
+
+        return $this;
+    }
+
+    public function toArray(): array
+    {
+        $data = [];
+        if ($this->walCapacityMb) {
+            $data['wal_capacity_mb'] = $this->walCapacityMb;
+        }
+        if ($this->walSegmentsAhead) {
+            $data['wal_segments_ahead'] = $this->walSegmentsAhead;
+        }
+
+        return $data;
+    }
+}

tests/Unit/Models/Request/CollectionConfig/HnswConfigTest.php

@@ -7,6 +7,7 @@
 namespace Qdrant\Tests\Unit\Models\Request\CollectionConfig;
 
 use PHPUnit\Framework\TestCase;
+use Qdrant\Exception\InvalidArgumentException;
 use Qdrant\Models\Request\CollectionConfig\HnswConfig;
 
 class HnswConfigTest extends TestCase
@@ -27,6 +28,15 @@ public function testWithM(): void
         ], $config->toArray());
     }
 
+    public function testWithInvalidM(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('m should be bigger than 0');
+        $config = (new HnswConfig())->setM(-1);
+
+        $this->assertEquals([], $config->toArray());
+    }
+
     public function testWithEfConstruct(): void
     {
         $config = (new HnswConfig())->setEfConstruct(10);
@@ -36,6 +46,15 @@ public function testWithEfConstruct(): void
         ], $config->toArray());
     }
 
+    public function testWithInvalidEfConstruct(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('ef_construct should be bigger than 4');
+        $config = (new HnswConfig())->setEfConstruct(-1);
+
+        $this->assertEquals([], $config->toArray());
+    }
+
     public function testWithFullScanThreshold(): void
     {
         $config = (new HnswConfig())->setFullScanThreshold(10);
@@ -45,7 +64,16 @@ public function testWithFullScanThreshold(): void
         ], $config->toArray());
     }
 
-    public function testWithDeletedThreshold(): void
+    public function testWithInvalidFullScanThreshold(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('full_scan_threshold should be bigger than 10');
+        $config = (new HnswConfig())->setFullScanThreshold(1);
+
+        $this->assertEquals([], $config->toArray());
+    }
+
+    public function testWithMaxIndexingThreads(): void
     {
         $config = (new HnswConfig())->setMaxIndexingThreads(9);
 
@@ -54,6 +82,15 @@ public function testWithDeletedThreshold(): void
         ], $config->toArray());
     }
 
+    public function testWithInvalidMaxIndexingThreads(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('max_indexing_threads should be bigger than 0');
+        $config = (new HnswConfig())->setMaxIndexingThreads(-1);
+
+        $this->assertEquals([], $config->toArray());
+    }
+
     public function testWithOnDisk(): void
     {
         $config = (new HnswConfig())->setOnDisk(true);
@@ -63,7 +100,7 @@ public function testWithOnDisk(): void
         ], $config->toArray());
     }
 
-    public function testWithDefaultSegmentNumber(): void
+    public function testWithPayloadM(): void
     {
         $config = (new HnswConfig())->setPayloadM(10);
 
@@ -72,7 +109,16 @@ public function testWithDefaultSegmentNumber(): void
         ], $config->toArray());
     }
 
-    public function testWithFlushIntervalSec(): void
+    public function testWithInvalidPayloadM(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('payload_m should be bigger than 0');
+        $config = (new HnswConfig())->setPayloadM(-1);
+
+        $this->assertEquals([], $config->toArray());
+    }
+
+    public function testWithMultipleParameters(): void
     {
         $config = (new HnswConfig())->setMaxIndexingThreads(10)->setPayloadM(10);
 

tests/Unit/Models/Request/CollectionConfig/WalConfigTest.php

@@ -0,0 +1,57 @@
+<?php
+/**
+ * @since     Oct 2023
+ * @author    Haydar KULEKCI <haydarkulekci@gmail.com>
+ */
+
+namespace Qdrant\Tests\Unit\Models\Request\CollectionConfig;
+
+use PHPUnit\Framework\TestCase;
+use Qdrant\Exception\InvalidArgumentException;
+use Qdrant\Models\Request\CollectionConfig\WalConfig;
+
+class WalConfigTest extends TestCase
+{
+    public function testBasic(): void
+    {
+        $config = new WalConfig();
+
+        $this->assertEquals([], $config->toArray());
+    }
+
+    public function testWithWalCapacityMb(): void
+    {
+        $config = (new WalConfig())->setWalCapacityMb(10);
+
+        $this->assertEquals([
+            'wal_capacity_mb' => 10
+        ], $config->toArray());
+    }
+
+    public function testWithInvalidM(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('wal_capacity_mb should be bigger than 1');
+        $config = (new WalConfig())->setWalCapacityMb(0);
+
+        $this->assertEquals([], $config->toArray());
+    }
+
+    public function testWithEfConstruct(): void
+    {
+        $config = (new WalConfig())->setWalSegmentsAhead(1);
+
+        $this->assertEquals([
+            'wal_segments_ahead' => 1
+        ], $config->toArray());
+    }
+
+    public function testWithInvalidEfConstruct(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('wal_segments_ahead should be bigger than 0');
+        $config = (new WalConfig())->setWalSegmentsAhead(-1);
+
+        $this->assertEquals([], $config->toArray());
+    }
+}