Skip to content

Commit 191dbba

Browse files
hkulekcihkulekci
committed
OptimizersConfigDiff renamed as OptimizersConfig
1 parent 42c9b2b commit 191dbba

6 files changed

Lines changed: 36 additions & 36 deletions

File tree

src/Models/Request/CollectionConfig/OptimizersConfigDiff.php renamed to src/Models/Request/CollectionConfig/OptimizersConfig.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* OptimizersConfigDiff
3+
* OptimizersConfig
44
*
55
* @since Mar 2023
66
* @author Haydar KULEKCI <haydarkulekci@gmail.com>
@@ -10,7 +10,7 @@
1010

1111
use Qdrant\Models\Request\RequestModel;
1212

13-
class OptimizersConfigDiff implements RequestModel
13+
class OptimizersConfig implements RequestModel
1414
{
1515
/** @var float|null The minimal fraction of deleted vectors in a segment, required to perform segment optimization */
1616
protected ?float $deletedThreshold = null;
@@ -51,56 +51,56 @@ class OptimizersConfigDiff implements RequestModel
5151
protected ?int $maxOptimizationThreads = null;
5252

5353

54-
public function setDeletedThreshold(?float $deletedThreshold): OptimizersConfigDiff
54+
public function setDeletedThreshold(?float $deletedThreshold): OptimizersConfig
5555
{
5656
$this->deletedThreshold = $deletedThreshold;
5757

5858
return $this;
5959
}
6060

61-
public function setIndexingThreshold(?int $indexingThreshold): OptimizersConfigDiff
61+
public function setIndexingThreshold(?int $indexingThreshold): OptimizersConfig
6262
{
6363
$this->indexingThreshold = $indexingThreshold;
6464

6565
return $this;
6666
}
6767

68-
public function setVacuumMinVectorNumber(?int $vacuumMinVectorNumber): OptimizersConfigDiff
68+
public function setVacuumMinVectorNumber(?int $vacuumMinVectorNumber): OptimizersConfig
6969
{
7070
$this->vacuumMinVectorNumber = $vacuumMinVectorNumber;
7171

7272
return $this;
7373
}
7474

75-
public function setDefaultSegmentNumber(?int $defaultSegmentNumber): OptimizersConfigDiff
75+
public function setDefaultSegmentNumber(?int $defaultSegmentNumber): OptimizersConfig
7676
{
7777
$this->defaultSegmentNumber = $defaultSegmentNumber;
7878

7979
return $this;
8080
}
8181

82-
public function setMaxSegmentSize(?int $maxSegmentSize): OptimizersConfigDiff
82+
public function setMaxSegmentSize(?int $maxSegmentSize): OptimizersConfig
8383
{
8484
$this->maxSegmentSize = $maxSegmentSize;
8585

8686
return $this;
8787
}
8888

89-
public function setMemmapThreshold(?int $memmapThreshold): OptimizersConfigDiff
89+
public function setMemmapThreshold(?int $memmapThreshold): OptimizersConfig
9090
{
9191
$this->memmapThreshold = $memmapThreshold;
9292

9393
return $this;
9494
}
9595

96-
public function setFlushIntervalSec(?int $flushIntervalSec): OptimizersConfigDiff
96+
public function setFlushIntervalSec(?int $flushIntervalSec): OptimizersConfig
9797
{
9898
$this->flushIntervalSec = $flushIntervalSec;
9999

100100
return $this;
101101
}
102102

103-
public function setMaxOptimizationThreads(?int $maxOptimizationThreads): OptimizersConfigDiff
103+
public function setMaxOptimizationThreads(?int $maxOptimizationThreads): OptimizersConfig
104104
{
105105
$this->maxOptimizationThreads = $maxOptimizationThreads;
106106

‎src/Models/Request/CreateCollection.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
use Qdrant\Models\Request\CollectionConfig\DisabledQuantization;
1212
use Qdrant\Models\Request\CollectionConfig\HnswConfig;
13-
use Qdrant\Models\Request\CollectionConfig\OptimizersConfigDiff;
13+
use Qdrant\Models\Request\CollectionConfig\OptimizersConfig;
1414
use Qdrant\Models\Request\CollectionConfig\QuantizationConfig;
1515
use Qdrant\Models\Request\CollectionConfig\WalConfig;
1616

@@ -29,7 +29,7 @@ class CreateCollection implements RequestModel
2929

3030
protected ?InitFrom $initFrom = null;
3131

32-
protected ?OptimizersConfigDiff $optimizersConfig = null;
32+
protected ?OptimizersConfig $optimizersConfig = null;
3333

3434
protected ?HnswConfig $hnswConfig = null;
3535

@@ -83,7 +83,7 @@ public function setInitFrom(InitFrom $initFrom): CreateCollection
8383
return $this;
8484
}
8585

86-
public function setOptimizersConfigDiff(OptimizersConfigDiff $optimizersConfig): CreateCollection
86+
public function setOptimizersConfig(OptimizersConfig $optimizersConfig): CreateCollection
8787
{
8888
$this->optimizersConfig = $optimizersConfig;
8989

‎src/Models/Request/UpdateCollection.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@
99
namespace Qdrant\Models\Request;
1010

1111
use Qdrant\Models\Request\CollectionConfig\DisabledQuantization;
12-
use Qdrant\Models\Request\CollectionConfig\OptimizersConfigDiff;
12+
use Qdrant\Models\Request\CollectionConfig\OptimizersConfig;
1313
use Qdrant\Models\Request\CollectionConfig\QuantizationConfig;
1414

1515
class UpdateCollection implements RequestModel
1616
{
17-
protected ?OptimizersConfigDiff $optimizersConfig = null;
17+
protected ?OptimizersConfig $optimizersConfig = null;
1818

1919
protected ?CollectionParamsDiff $collectionParamsDiff = null;
2020

2121
protected ?QuantizationConfig $quantizationConfig = null;
2222

23-
public function setOptimizersConfigDiff(OptimizersConfigDiff $optimizersConfig): UpdateCollection
23+
public function setOptimizersConfig(OptimizersConfig $optimizersConfig): UpdateCollection
2424
{
2525
$this->optimizersConfig = $optimizersConfig;
2626

‎tests/Integration/Endpoints/CollectionsTest.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
use Qdrant\Endpoints\Collections;
1111
use Qdrant\Exception\InvalidArgumentException;
12-
use Qdrant\Models\Request\CollectionConfig\OptimizersConfigDiff;
12+
use Qdrant\Models\Request\CollectionConfig\OptimizersConfig;
1313
use Qdrant\Models\Request\CreateCollection;
1414
use Qdrant\Models\Request\InitFrom;
1515
use Qdrant\Models\Request\UpdateCollection;
@@ -129,8 +129,8 @@ public function testUpdateCollection(): void
129129
$this->assertEquals('green', $response['result']['status']);
130130

131131
$response = $collections->update(
132-
(new UpdateCollection())->setOptimizersConfigDiff(
133-
(new OptimizersConfigDiff())
132+
(new UpdateCollection())->setOptimizersConfig(
133+
(new OptimizersConfig())
134134
->setIndexingThreshold(10000)
135135
)
136136
);
@@ -148,8 +148,8 @@ public function testCreateCollectionWithOptimizersConfig(): void
148148

149149
$request = (new CreateCollection())
150150
->addVector(new VectorParams(300, VectorParams::DISTANCE_COSINE), 'image')
151-
->setOptimizersConfigDiff(
152-
(new OptimizersConfigDiff())->setIndexingThreshold(10000)
151+
->setOptimizersConfig(
152+
(new OptimizersConfig())->setIndexingThreshold(10000)
153153
);
154154

155155
$response = $collections->create($request);

tests/Unit/Models/Request/CollectionConfig/OptimizerConfigDiffTest.php renamed to tests/Unit/Models/Request/CollectionConfig/OptimizerConfigTest.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,20 @@
77
namespace Qdrant\Tests\Unit\Models\Request\CollectionConfig;
88

99
use PHPUnit\Framework\TestCase;
10-
use Qdrant\Models\Request\CollectionConfig\OptimizersConfigDiff;
10+
use Qdrant\Models\Request\CollectionConfig\OptimizersConfig;
1111

12-
class OptimizerConfigDiffTest extends TestCase
12+
class OptimizerConfigTest extends TestCase
1313
{
1414
public function testBasic(): void
1515
{
16-
$config = new OptimizersConfigDiff();
16+
$config = new OptimizersConfig();
1717

1818
$this->assertEquals([], $config->toArray());
1919
}
2020

2121
public function testWithIndexingThreshold(): void
2222
{
23-
$config = (new OptimizersConfigDiff())->setIndexingThreshold(10);
23+
$config = (new OptimizersConfig())->setIndexingThreshold(10);
2424

2525
$this->assertEquals([
2626
'indexing_threshold' => 10
@@ -29,7 +29,7 @@ public function testWithIndexingThreshold(): void
2929

3030
public function testWithMaxOptimizationThreads(): void
3131
{
32-
$config = (new OptimizersConfigDiff())->setMaxOptimizationThreads(10);
32+
$config = (new OptimizersConfig())->setMaxOptimizationThreads(10);
3333

3434
$this->assertEquals([
3535
'max_optimization_threads' => 10
@@ -38,7 +38,7 @@ public function testWithMaxOptimizationThreads(): void
3838

3939
public function testWithMaxSegmentSize(): void
4040
{
41-
$config = (new OptimizersConfigDiff())->setMaxSegmentSize(10);
41+
$config = (new OptimizersConfig())->setMaxSegmentSize(10);
4242

4343
$this->assertEquals([
4444
'max_segment_size' => 10
@@ -47,7 +47,7 @@ public function testWithMaxSegmentSize(): void
4747

4848
public function testWithDeletedThreshold(): void
4949
{
50-
$config = (new OptimizersConfigDiff())->setDeletedThreshold(9.8);
50+
$config = (new OptimizersConfig())->setDeletedThreshold(9.8);
5151

5252
$this->assertEquals([
5353
'deleted_threshold' => 9.8
@@ -56,7 +56,7 @@ public function testWithDeletedThreshold(): void
5656

5757
public function testWithMemmapThreshold(): void
5858
{
59-
$config = (new OptimizersConfigDiff())->setMemmapThreshold(10);
59+
$config = (new OptimizersConfig())->setMemmapThreshold(10);
6060

6161
$this->assertEquals([
6262
'memmap_threshold' => 10
@@ -65,7 +65,7 @@ public function testWithMemmapThreshold(): void
6565

6666
public function testWithDefaultSegmentNumber(): void
6767
{
68-
$config = (new OptimizersConfigDiff())->setDefaultSegmentNumber(10);
68+
$config = (new OptimizersConfig())->setDefaultSegmentNumber(10);
6969

7070
$this->assertEquals([
7171
'default_segment_number' => 10
@@ -74,7 +74,7 @@ public function testWithDefaultSegmentNumber(): void
7474

7575
public function testWithFlushIntervalSec(): void
7676
{
77-
$config = (new OptimizersConfigDiff())->setFlushIntervalSec(10);
77+
$config = (new OptimizersConfig())->setFlushIntervalSec(10);
7878

7979
$this->assertEquals([
8080
'flush_interval_sec' => 10
@@ -83,7 +83,7 @@ public function testWithFlushIntervalSec(): void
8383

8484
public function testWithVacuumMinVectorNumber(): void
8585
{
86-
$config = (new OptimizersConfigDiff())->setVacuumMinVectorNumber(10);
86+
$config = (new OptimizersConfig())->setVacuumMinVectorNumber(10);
8787

8888
$this->assertEquals([
8989
'vacuum_min_vector_number' => 10

‎tests/Unit/Models/Request/CreateCollectionTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
use PHPUnit\Framework\TestCase;
99
use Qdrant\Models\Request\CollectionConfig\HnswConfig;
10-
use Qdrant\Models\Request\CollectionConfig\OptimizersConfigDiff;
10+
use Qdrant\Models\Request\CollectionConfig\OptimizersConfig;
1111
use Qdrant\Models\Request\CollectionConfig\WalConfig;
1212
use Qdrant\Models\Request\CreateCollection;
1313
use Qdrant\Models\Request\VectorParams;
@@ -143,15 +143,15 @@ public function testCreateCollectionWithOnDiskPayload(): void
143143
);
144144
}
145145

146-
public function testCreateCollectionWithOptimizersConfigDiff(): void
146+
public function testCreateCollectionWithOptimizersConfig(): void
147147
{
148148
$collection = new CreateCollection();
149149
$collection->addVector(new VectorParams(1024, VectorParams::DISTANCE_COSINE));
150-
$diff = (new OptimizersConfigDiff())
150+
$diff = (new OptimizersConfig())
151151
->setMaxSegmentSize(1)
152152
->setDefaultSegmentNumber(1);
153153

154-
$collection->setOptimizersConfigDiff($diff);
154+
$collection->setOptimizersConfig($diff);
155155

156156
$this->assertEquals(
157157
[

0 commit comments

Comments
 (0)