ServerException changed as extending RuntimeException. And test improved for response class.

Author: hkulekci

src/Exception/ServerException.php

@@ -10,7 +10,7 @@
 
 use Qdrant\Response;
 
-class ServerException extends \Exception
+class ServerException extends \RuntimeException
 {
     protected Response $response;
 

src/Http/GuzzleClient.php

@@ -7,7 +7,6 @@
 
 use GuzzleHttp\Client;
 use GuzzleHttp\Exception\ClientException;
-use GuzzleHttp\Exception\GuzzleException;
 use JsonException;
 use Psr\Http\Client\ClientExceptionInterface;
 use Psr\Http\Message\RequestInterface;

src/Response.php

@@ -33,11 +33,13 @@ public function __construct(protected ResponseInterface $response)
         }
 
         if ($this->response->getStatusCode() >= 400 && $this->response->getStatusCode() < 500) {
-            throw (new InvalidArgumentException($this->raw['status']['error'] ?? 'Invalid argument exception'))->setResponse($this);
+            throw (new InvalidArgumentException(
+                $this->raw['status']['error'] ?? 'Invalid argument exception',
+                $this->response->getStatusCode()))->setResponse($this);
         }
 
-        if ($this->response->getStatusCode() >= 500 && $this->response->getStatusCode() < 500) {
-            throw (new ServerException())->setResponse($this);
+        if ($this->response->getStatusCode() >= 500) {
+            throw (new ServerException('Server Exception', $this->response->getStatusCode()))->setResponse($this);
         }
     }
 

tests/Unit/ResponseTest.php

@@ -0,0 +1,78 @@
+<?php
+/**
+ * @since     Mar 2023
+ * @author    Haydar KULEKCI <haydarkulekci@gmail.com>
+ */
+
+namespace Qdrant\Tests\Unit;
+
+use GuzzleHttp\Psr7\Response as HttpResponse;
+use GuzzleHttp\Psr7\Utils;
+use PHPUnit\Framework\TestCase;
+use Psr\Http\Message\ResponseInterface;
+use Qdrant\Exception\InvalidArgumentException;
+use Qdrant\Exception\ServerException;
+use Qdrant\Response;
+
+class ResponseTest extends TestCase
+{
+    public function testConstructResponse(): void
+    {
+        $httpResponse = new HttpResponse(
+            200,
+            [
+                'content-type' => 'application/json'
+            ],
+            Utils::streamFor(json_encode(['foo' => 'bar']))
+        );
+
+        $response = new Response($httpResponse);
+
+        $this->assertEquals('bar', $response['foo']);
+    }
+
+    public function testConstructResponse2(): void
+    {
+        $httpResponse = new HttpResponse(
+            200,
+            [
+                'content-type' => 'text/html'
+            ],
+            Utils::streamFor(json_encode(['foo' => 'bar']))
+        );
+
+        $response = new Response($httpResponse);
+
+        $this->assertEquals('{"foo":"bar"}', $response['content']);
+    }
+
+    public function testConstructResponseWith4xxHttpCode(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Invalid argument exception');
+        $this->expectExceptionCode(418);
+        $httpResponse = new HttpResponse(
+            418,
+            [
+                'content-type' => 'application/json'
+            ],
+            Utils::streamFor(json_encode(['foo' => 'bar']))
+        );
+
+        new Response($httpResponse);
+    }
+
+    public function testConstructResponseWith5xxHttpCode(): void
+    {
+        $this->expectException(ServerException::class);
+        $this->expectExceptionMessage('Server Exception');
+        $this->expectExceptionCode(510);
+        $httpResponse = new HttpResponse(
+            510,
+            [],
+            Utils::streamFor(json_encode(['foo' => 'bar']))
+        );
+
+        new Response($httpResponse);
+    }
+}