Merge pull request #309 from pptasinski-bitbag/master

make sitemap providers optional

Author: patrick477

doc/installation.md

@@ -54,6 +54,16 @@ bitbag_sylius_cms_plugin:
     resource: "@BitBagSyliusCmsPlugin/Resources/config/routing.yml"
 ```
 
+Import optional sitemap providers:
+```yaml
+# config/services.yaml
+...
+imports:
+...
+    - { resource: "@BitBagSyliusCmsPlugin/Resources/config/services/sitemap_provider.yml" }
+```
+
+
 Finish the installation by updating the database schema and installing assets:
 ```
 $ bin/console doctrine:migrations:diff

src/Resources/config/services.yml

@@ -51,25 +51,3 @@ services:
         factory: ['@knp_gaufrette.filesystem_map', get]
         arguments:
             - "%bitbag_sylius_cms_plugin.uploader.filesystem%"
-
-    bitbag_sylius_cms_plugin.sitemap_provider.page:
-        class: BitBag\SyliusCmsPlugin\SitemapProvider\PageUrlProvider
-        arguments:
-            - "@bitbag_sylius_cms_plugin.repository.page"
-            - "@router"
-            - "@sylius.sitemap_url_factory"
-            - "@sylius.context.locale"
-            - "@sylius.context.channel"
-        tags:
-            - { name: sylius.sitemap_provider }
-
-    bitbag_sylius_cms_plugin.sitemap_provider.section:
-        class: BitBag\SyliusCmsPlugin\SitemapProvider\SectionUrlProvider
-        arguments:
-            - "@bitbag_sylius_cms_plugin.repository.section"
-            - "@router"
-            - "@sylius.sitemap_url_factory"
-            - "@sylius.context.locale"
-            - "@sylius.context.channel"
-        tags:
-            - { name: sylius.sitemap_provider }

src/Resources/config/services/sitemap_provider.yml

@@ -0,0 +1,22 @@
+services:
+  bitbag_sylius_cms_plugin.sitemap_provider.page:
+    class: BitBag\SyliusCmsPlugin\SitemapProvider\PageUrlProvider
+    arguments:
+      - "@bitbag_sylius_cms_plugin.repository.page"
+      - "@router"
+      - "@sylius.sitemap_url_factory"
+      - "@sylius.context.locale"
+      - "@sylius.context.channel"
+    tags:
+      - { name: sylius.sitemap_provider }
+
+  bitbag_sylius_cms_plugin.sitemap_provider.section:
+    class: BitBag\SyliusCmsPlugin\SitemapProvider\SectionUrlProvider
+    arguments:
+      - "@bitbag_sylius_cms_plugin.repository.section"
+      - "@router"
+      - "@sylius.sitemap_url_factory"
+      - "@sylius.context.locale"
+      - "@sylius.context.channel"
+    tags:
+      - { name: sylius.sitemap_provider }

tests/Application/config/services.yaml

@@ -2,3 +2,5 @@
 # https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
 parameters:
     locale: en_US
+imports:
+    - { resource: "@BitBagSyliusCmsPlugin/Resources/config/services/sitemap_provider.yml" }