From f9244fe54278c611fc12bcde4ec7ee011c7f4427 Mon Sep 17 00:00:00 2001 From: Huderon Date: Sat, 29 Aug 2026 17:46:09 +1000 Subject: [PATCH] fix: kill discord before writing betterdiscord.asar --- discord/install.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/discord/install.go b/discord/install.go index 0d6c328..48ada55 100644 --- a/discord/install.go +++ b/discord/install.go @@ -41,20 +41,20 @@ func (discord *DiscordInstall) InstallBD(options types.InstallOptions) error { log.Println("✅ BetterDiscord prepared for install") log.Println("") - // Download and write betterdiscord.asar - log.Println("📥 Downloading BetterDiscord...") - if err := bd.Download(options.UseDevBuild); err != nil { + // Discord locks app.asar and betterdiscord.asar while running, so it must be stopped before we can + // modify it. Capture the executable so it can be relaunched afterward. + exe, wasRunning, err := discord.stop() + if err != nil { return err } - log.Println("✅ BetterDiscord downloaded") log.Println("") - // Discord locks app.asar while running, so it must be stopped before we can - // modify it. Capture the executable so it can be relaunched afterward. - exe, wasRunning, err := discord.stop() - if err != nil { + // Download and write betterdiscord.asar + log.Println("📥 Downloading BetterDiscord...") + if err := bd.Download(options.UseDevBuild); err != nil { return err } + log.Println("✅ BetterDiscord downloaded") log.Println("") // Shadow app.asar with our loader