Bugfix: LBNL folder should not prefix path with / (DEV-46)

Author: Daniel Schmidt

lib/berkeley_library/sftp_handler/downloader/lbnl.rb

@@ -13,7 +13,7 @@ module Downloader
       class Lbnl < Base
         def download!(filename: nil, local_dir: '/opt/app/data')
           filename ||= default_filename
-          remote_path = Pathname.new('/') + filename
+          remote_path = Pathname.new(filename)
           local_path = Pathname.new(local_dir) + filename
           assert_not_exists! local_path
 

spec/downloader/lbnl_spec.rb

@@ -10,7 +10,7 @@
     let(:now) { Time.new(2022, 5, 25, 0, 0, 0) }
     let(:last_weeks_filename) { 'lbnl_people_20220516.zip' }
     let(:this_weeks_filename) { 'lbnl_people_20220523.zip' }
-    let(:todays_remote_path) { Pathname.new("/#{this_weeks_filename}") }
+    let(:todays_remote_path) { Pathname.new(this_weeks_filename) }
     let(:sftp_session) { instance_double(Net::SFTP::Session) }
 
     before do
@@ -44,7 +44,7 @@
 
     it "downloads a specific file" do
       filename = 'lbnl_people_20220516.zip'
-      remote_path = Pathname.new("/#{filename}")
+      remote_path = Pathname.new(filename)
       local_path = Pathname.new("/opt/app/data/#{filename}")
 
       expect(sftp_session)