diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a770b87..0b7e04f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -141,6 +141,10 @@ jobs: if: ${{ steps.release_signing.outputs.enabled == 'true' }} run: gradle --no-daemon --stacktrace :app:assembleRelease + - name: Verify production manifest privacy boundary + if: ${{ steps.release_signing.outputs.enabled == 'true' }} + run: python scripts/verify_release_manifest.py app/build/outputs/apk/release/app-release.apk "$ANDROID_HOME/build-tools/37.0.0/aapt2" + - name: Verify release APK signature and report hashes if: ${{ steps.release_signing.outputs.enabled == 'true' }} shell: bash @@ -203,10 +207,14 @@ jobs: echo "APK SHA-256: ${hash}" echo "Certificate SHA-256: 4D:2F:17:89:ED:27:D3:96:13:35:FE:36:45:64:55:BD:9A:31:0B:0D:CD:F4:1E:8C:CC:92:53:98:33:9E:80:BF" echo - echo "TEST BUILD: Phase 1 is incomplete and not yet verified on a physical phone. This release is for Obtainium installation/update pipeline testing; follow docs/PHASE1_PHONE_TEST.md." + echo "PHASE 1 PHONE-TEST CANDIDATE: one read-only local folder, recursive video/subtitle discovery, offline Room library, grouped episodes, safe rescans/cancellation and permission recovery. Automated verification is separate from real OPPO acceptance." + echo + echo "Phone test: update without uninstalling; select a nested local test folder; scan; reopen in airplane mode; add/remove a test file and rescan; cancel a scan; switch folders; reconnect after permission loss. Confirm no outside files or source modifications." + echo "Full checklist: https://github.com/Batmancpu/Player/blob/main/docs/PHASE1_PHONE_TEST.md" + echo "Phase 1 remains unaccepted until the actual OPPO Reno10 CPH2531 report. No handset FPS measurement is claimed." } > "$RUNNER_TEMP/release-notes.md" gh release create "$tag" "$release_apk" \ - --title "Player ${tag} — test APK (not accepted)" \ + --title "Player ${tag} — Phase 1 phone-test candidate" \ --notes-file "$RUNNER_TEMP/release-notes.md" \ --latest \ --target "${GITHUB_SHA}" diff --git a/AGENTS.md b/AGENTS.md index 4dfdcec..52dfb5e 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -175,3 +175,9 @@ If chat context is lost, these repository records are the handoff. Do not invent - 2026-11-14 — Parser corpus slice: preserve leading numeric movie titles/use trailing release year and keep multi-episode ambiguity under original filenames. Regression fixtures added; CI pending a focused parser PR after Android harness gate. Next: verify corpus and finish plain library states/grouping before candidate release. - 2026-11-14 — Plain-library completion slice: cached loading, initial empty, completed-empty and cancelled states; series-grouped episode list with memoized parsing and safe system insets. LibrarySession exposes completion/cancel flags. Unverified pending focused CI; no Glass/network addition. Next: validate Android/filename/UI gates and publish a signed Phase 1 candidate. + +- 2026-11-14 — Release-candidate preparation: built-APK manifest gate checks fixed identity/run version, offline permission allowlist, backup disabled and debug-provider exclusion. Release notes now give Phase 1 feature/checklist and retain unaccepted status. Unverified until signed main gate; publication remains explicit release(test) trigger only. Next: finish CI and publish verified candidate. + +- 2026-11-14 — Candidate attribution: packaged Apache-2.0 text and runtime-library source/author notices alongside existing Lucide license; no new runtime dependency/source copied. Verified Haze license at shipped tag 2.1.0. Syntax check passed for release-manifest script; signed APK check pending. Next: finish Android suite and manifest gate, publish candidate. + +- 2026-11-14 — Android integration PR #6 passed CI 43615935921: all nine Android 15 emulator tests passed (Room/cursor/privacy/launcher recreation). Parser/plain UI PR #7 passed CI 43616107190 and merged. OPPO/actual SAF provider acceptance remains pending. Next: final release manifest gate then explicitly publish signed Phase 1 candidate. diff --git a/DEVELOPMENT_LOG.md b/DEVELOPMENT_LOG.md index a452b99..273410d 100644 --- a/DEVELOPMENT_LOG.md +++ b/DEVELOPMENT_LOG.md @@ -580,3 +580,14 @@ Implement one isolated Glass laboratory screen with a fixed local gradient/artwo ## 2026-11-14 — Plain offline library states and series grouping - LibrarySession adds explicit completed-scan/cancelled flags; cache restoration alone does not claim a completed empty scan. FolderSetupScreen adds saved-cache loading and empty/cancel status text, groups episodes by parsed series then season/episode, memoizes parsing/grouping, and respects safe system insets. Strings are resource-backed; no Glass or network. - This slice remains unverified until its own PR gate; actual TalkBack/large-font/OPPO rendering checks belong to the phone checklist. No phase acceptance/FPS claim. + +## 2026-11-14 — Phase 1 release boundary and candidate notes +- scripts/verify_release_manifest.py uses standard aapt2 on the built signed APK: fixed app ID, expected run-number versionCode, only AndroidX internal signature permission, allowBackup=false, no debug synthetic provider. Signing secrets/media contents are never read. CI runs this after release assembly before publication. +- Release title/notes now describe the functional Phase 1 phone-test candidate and short/full checklist instead of update-pipeline-only testing. Still explicitly unaccepted without OPPO report; no FPS claim. No signature/key/versioning design change; explicit release(test) main push or manual dispatch remains required. Verification pending signed build; no Release published yet. + +- Release attribution follow-up: THIRD_PARTY_NOTICES.md plus packaged APACHE_2_0.txt/DEPENDENCIES.md cover existing AndroidX/Kotlin/coroutines/Haze runtime licenses alongside Lucide ISC/MIT. Haze root license read at tag 2.1.0, blob 261eeb9e9f8b2b4b0d119366dda99c6fd7d35c64; no upstream app code/assets copied. `python -m py_compile scripts/verify_release_manifest.py` passed locally; real APK assertion pending signed gate. + +## 2026-11-14 — Android and plain-library verification completed +- Android PR #6 be24e38, CI https://github.com/Batmancpu/Player/actions/runs/43615935921 succeeded. Android job 132510883667 logs: Starting 9 tests on Android 15 AVD; BUILD SUCCESSFUL in 4m 11s, no failed tests. Tests cover Room/SAF helper and launcher recreation; synthetic provider, not actual OPPO external-storage DocumentsProvider or measured frame timing. +- Parser/UI PR #7 fec88a9 passed unit/debug/test-APK CI 43616107190, merged as 3d5d6f4. No source/automated failures observed in those gates. Main combined test/signing gate plus actual release-manifest assertion still required before publication. +- Next: merge release notes/manifest/attribution preparation, inspect signed main privacy gate; only then explicit release(test) publication. Phase 1 remains awaiting real-device acceptance. diff --git a/THIRD_PARTY_NOTICES.md b/THIRD_PARTY_NOTICES.md index 3c6aa51..6614b0b 100644 --- a/THIRD_PARTY_NOTICES.md +++ b/THIRD_PARTY_NOTICES.md @@ -12,3 +12,7 @@ This file records third-party code/assets shipped in the Player APK. Each includ - License: ISC, with MIT terms for portions derived from Feather. The complete notice is packaged at `app/src/main/assets/licenses/LUCIDE_ICONS_LICENSE.md`. No Apple SF Symbols glyphs, Apple logos or SF font files are bundled. + + +## Runtime libraries +AndroidX/Jetpack (Android Open Source Project and contributors), Kotlin/kotlinx.coroutines (JetBrains and contributors), and Haze 2.1.0 (Chris Banes and contributors) use Apache-2.0. Packaged license/attribution: `app/src/main/assets/licenses/APACHE_2_0.txt` and `DEPENDENCIES.md`. Haze license verified at tag 2.1.0: https://github.com/chrisbanes/haze/blob/2.1.0/LICENSE. Build tooling and AndroidX Test/JUnit are development/test dependencies, not runtime feature additions. Retain upstream per-file copyright and any applicable NOTICE when adapting code. diff --git a/app/src/main/assets/licenses/APACHE_2_0.txt b/app/src/main/assets/licenses/APACHE_2_0.txt new file mode 100644 index 0000000..57bc88a --- /dev/null +++ b/app/src/main/assets/licenses/APACHE_2_0.txt @@ -0,0 +1,202 @@ + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against any entity (including a + cross-claim or counterclaim in a lawsuit) alleging that the Work + or a Contribution incorporated within the Work constitutes direct + or contributory patent infringement, then any patent licenses + granted to You under this License for that Work shall terminate + as of the date such litigation is filed. + + 4. Redistribution. You may reproduce and distribute copies of the + Work or Derivative Works thereof in any medium, with or without + modifications, and in Source or Object form, provided that You + meet the following conditions: + + (a) You must give any other recipients of the Work or + Derivative Works a copy of this License; and + + (b) You must cause any modified files to carry prominent notices + stating that You changed the files; and + + (c) You must retain, in the Source form of any Derivative Works + that You distribute, all copyright, patent, trademark, and + attribution notices from the Source form of the Work, + excluding those notices that do not pertain to any part of + the Derivative Works; and + + (d) If the Work includes a "NOTICE" text file as part of its + distribution, then any Derivative Works that You distribute must + include a readable copy of the attribution notices contained + within such NOTICE file, excluding those notices that do not + pertain to any part of the Derivative Works, in at least one + of the following places: within a NOTICE text file distributed + as part of the Derivative Works; within the Source form or + documentation, if provided along with the Derivative Works; or, + within a display generated by the Derivative Works, if and + wherever such third-party notices normally appear. The contents + of the NOTICE file are for informational purposes only and + do not modify the License. You may add Your own attribution + notices within Derivative Works that You distribute, alongside + or as an addendum to the NOTICE text from the Work, provided + that such additional attribution notices cannot be construed + as modifying the License. + + You may add Your own copyright statement to Your modifications and + may provide additional or different license terms and conditions + for use, reproduction, or distribution of Your modifications, or + for any such Derivative Works as a whole, provided Your use, + reproduction, and distribution of the Work otherwise complies with + the conditions stated in this License. + + 5. Submission of Contributions. Unless You explicitly state otherwise, + any Contribution intentionally submitted for inclusion in the Work + by You to the Licensor shall be under the terms and conditions of + this License, without any additional terms or conditions. + Notwithstanding the above, nothing herein shall supersede or modify + the terms of any separate license agreement you may have executed + with Licensor regarding such Contributions. + + 6. Trademarks. This License does not grant permission to use the trade + names, trademarks, service marks, or product names of the Licensor, + except as required for reasonable and customary use in describing the + origin of the Work and reproducing the content of the NOTICE file. + + 7. Disclaimer of Warranty. Unless required by applicable law or + agreed to in writing, Licensor provides the Work (and each + Contributor provides its Contributions) on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied, including, without limitation, any warranties or conditions + of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A + PARTICULAR PURPOSE. You are solely responsible for determining the + appropriateness of using or redistributing the Work and assume any + risks associated with Your exercise of permissions under this License. + + 8. Limitation of Liability. In no event and under no legal theory, + whether in tort (including negligence), contract, or otherwise, + unless required by applicable law (such as deliberate and grossly + negligent acts) or agreed to in writing, shall any Contributor be + liable to You for damages, including any direct, indirect, special, + incidental, or consequential damages of any character arising as a + result of this License or out of the use or inability to use the + Work (including but not limited to damages for loss of goodwill, + work stoppage, computer failure or malfunction, or any and all + other commercial damages or losses), even if such Contributor + has been advised of the possibility of such damages. + + 9. Accepting Warranty or Additional Liability. While redistributing + the Work or Derivative Works thereof, You may choose to offer, + and charge a fee for, acceptance of support, warranty, indemnity, + or other liability obligations and/or rights consistent with this + License. However, in accepting such obligations, You may act only + on Your own behalf and on Your sole responsibility, not on behalf + of any other Contributor, and only if You agree to indemnify, + defend, and hold each Contributor harmless for any liability + incurred by, or claims asserted against, such Contributor by reason + of your accepting any such warranty or additional liability. + + END OF TERMS AND CONDITIONS + + APPENDIX: How to apply the Apache License to your work. + + To apply the Apache License to your work, attach the following + boilerplate notice, with the fields enclosed by brackets "[]" + replaced with your own identifying information. (Don't include + the brackets!) The text should be enclosed in the appropriate + comment syntax for the file format. We also recommend that a + file or class name and description of purpose be included on the + same "printed page" as the copyright notice for easier + identification within third-party archives. + + Copyright [yyyy] [name of copyright owner] + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + diff --git a/app/src/main/assets/licenses/DEPENDENCIES.md b/app/src/main/assets/licenses/DEPENDENCIES.md new file mode 100644 index 0000000..139196f --- /dev/null +++ b/app/src/main/assets/licenses/DEPENDENCIES.md @@ -0,0 +1,10 @@ +# Player dependency attribution + +The Android release uses AndroidX / Jetpack (Android Open Source Project and contributors), Kotlin standard libraries and kotlinx.coroutines (JetBrains and contributors), and Haze (Chris Banes and contributors). These projects use the Apache License 2.0, included as APACHE_2_0.txt. Individual upstream copyright and applicable notices remain with their original owners. + +- AndroidX / Compose / Room / Activity / Core: https://android.googlesource.com/platform/frameworks/support/ +- Kotlin: https://github.com/JetBrains/kotlin +- kotlinx.coroutines: https://github.com/Kotlin/kotlinx.coroutines +- Haze 2.1.0 (core, Glass, Material integration): https://github.com/chrisbanes/haze/tree/2.1.0 + +Lucide vector attribution and full ISC/MIT notices are in LUCIDE_ICONS_LICENSE.md. No Apple fonts, SF Symbols glyphs or proprietary graphics are distributed. Dependency versions are pinned in the Gradle build; no upstream application was transplanted. diff --git a/scripts/verify_release_manifest.py b/scripts/verify_release_manifest.py new file mode 100644 index 0000000..1e9687a --- /dev/null +++ b/scripts/verify_release_manifest.py @@ -0,0 +1,25 @@ +"""Verify the built APK boundary; no private media or signing material is read.""" +import os +import re +import subprocess +import sys + +apk, aapt = sys.argv[1:] + +def dump(*args): + return subprocess.run([aapt, "dump", *args, apk], check=True, capture_output=True, text=True).stdout + +badging = dump("badging") +package = re.search(r"package: name='([^']+)' versionCode='(\d+)'", badging) +assert package and package[1] == "com.batmancpu.player", "Application identity changed" +assert int(package[2]) == int(os.environ["GITHUB_RUN_NUMBER"]), "Unexpected versionCode" +permissions = dump("permissions") +allowed = {"com.batmancpu.player.DYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION"} +for line in permissions.splitlines(): + if line.startswith("uses-permission"): + permission = re.search(r"name='([^']+)'", line) + assert permission and permission[1] in allowed, "Unexpected production permission" +xml = dump("xmltree", "--file", "AndroidManifest.xml") +assert re.search(r"android:allowBackup[^\n]*\(type 0x12\)0x0\b", xml), "Backup must remain disabled" +assert "SyntheticSafProvider" not in xml and "com.batmancpu.player.synthetic" not in xml, "Debug provider entered release" +print("Release manifest verified: stable identity/version, offline permissions, backup disabled, no debug provider.")