Commit aab852d
Fix performance test flake on CI (#152)
Fix flaky `should measure elapsed time accurately` test on CI.
## The Bug
`setTimeout` only guarantees a minimum delay, not a maximum. On busy CI
agents (especially macOS), the callback can fire well beyond the 100ms
tolerance window, causing `assertBelow` to fail.
## The Fix
Remove the upper-bound assertion — only verify that elapsed time is at
least the requested delay. The test still validates that
`performance.now()` returns accurate, monotonically increasing values.
Also removes the now-unused `sanitizersEnabled` plumbing (CMake define,
C++ global, TS declaration) since this was its only consumer.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 598f004 commit aab852d
3 files changed
Lines changed: 2 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 49 | | |
54 | 50 | | |
55 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
1235 | 1234 | | |
1236 | 1235 | | |
1237 | 1236 | | |
1238 | | - | |
1239 | 1237 | | |
1240 | 1238 | | |
| 1239 | + | |
| 1240 | + | |
1241 | 1241 | | |
1242 | | - | |
1243 | 1242 | | |
1244 | 1243 | | |
1245 | 1244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | 87 | | |
94 | 88 | | |
95 | 89 | | |
| |||
0 commit comments