Fixed address sanitizer flags when using clang on windows (#142)

Author: SergioRZMasson

CMakeLists.txt

@@ -92,7 +92,10 @@ if(ENABLE_SANITIZERS)
         set(SANITIZERS "address,undefined")
         # Check for Clang since vptr and fdsan are Clang-specific
         if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-            list(APPEND SANITIZERS "vptr")
+            # vptr is not supported on Windows.
+            if(NOT WIN32)
+                list(APPEND SANITIZERS "vptr")
+            endif()
             # FDSan only works on Android builds with Clang
             if (ANDROID)
                 list(APPEND SANITIZERS "fdsan")

Tests/UnitTests/CMakeLists.txt

@@ -46,6 +46,10 @@ endif()
 add_executable(UnitTests ${SOURCES} ${SCRIPTS} ${TYPE_SCRIPTS} ${ASSETS})
 target_compile_definitions(UnitTests PRIVATE JSRUNTIMEHOST_PLATFORM="${JSRUNTIMEHOST_PLATFORM}")
 
+if(ENABLE_SANITIZERS)
+    target_compile_definitions(UnitTests PRIVATE JSRUNTIMEHOST_SANITIZERS_ENABLED=1)
+endif()
+
 target_link_libraries(UnitTests
     PRIVATE AppRuntime
     PRIVATE Console

Tests/UnitTests/Scripts/tests.ts

@@ -7,6 +7,7 @@ Mocha.reporter('spec');
 
 declare const hostPlatform: string;
 declare const setExitCode: (code: number) => void;
+declare const sanitizersEnabled: boolean;
 
 
 describe("AbortController", function () {
@@ -1234,11 +1235,11 @@ describe("Performance", function () {
     it("should measure elapsed time accurately", function (done) {
         const start = performance.now();
         const delay = 50;
+        const tolerance = sanitizersEnabled ? 500 : 100;
         setTimeout(() => {
             const elapsed = performance.now() - start;
-            // Allow some tolerance (elapsed should be at least the delay, but could be slightly more)
             expect(elapsed).to.be.at.least(delay - 5);
-            expect(elapsed).to.be.lessThan(delay + 100); // generous upper bound
+            expect(elapsed).to.be.lessThan(delay + tolerance);
             done();
         }, delay);
     });

Tests/UnitTests/Shared/Shared.cpp

@@ -80,6 +80,12 @@ TEST(JavaScript, All)
         env.Global().Set("setExitCode", setExitCodeCallback);
 
         env.Global().Set("hostPlatform", Napi::Value::From(env, JSRUNTIMEHOST_PLATFORM));
+
+#ifdef JSRUNTIMEHOST_SANITIZERS_ENABLED
+        env.Global().Set("sanitizersEnabled", Napi::Value::From(env, true));
+#else
+        env.Global().Set("sanitizersEnabled", Napi::Value::From(env, false));
+#endif
     });
 
     Babylon::ScriptLoader loader{runtime};