Update to Babylon fork of v8 binary for Android (#133)

We recently forked the v8-android-buildscripts OSS repo to get it
building again and to enable a new compiler flag needed for the Android
Play Store (details here:
BabylonJS/v8-android-buildscripts#1).

This PR switches over to the new Babylon forked package
([@babylonjs/v8-android-jit-nointl-nosnapshot](https://www.npmjs.com/package/@babylonjs/v8-android-jit-nointl-nosnapshot)).

Author: ryantrem

Core/AppRuntime/V8Inspector/Include/V8Inc.h

@@ -9,7 +9,7 @@
 #ifndef V8_31BIT_SMIS_ON_64BIT_ARCH
 #define V8_31BIT_SMIS_ON_64BIT_ARCH 1
 #endif
-#ifndef V8_ENABLE_SANDBOX
+#if !defined(ANDROID) && !defined(V8_ENABLE_SANDBOX)
 #define V8_ENABLE_SANDBOX 1
 #endif
 #endif

Core/AppRuntime/V8Inspector/Source/V8InspectorAgent.cpp

@@ -194,14 +194,7 @@ namespace Babylon
 
         void ConnectFrontend()
         {
-            session_ = inspector_->connect(
-                1, new ChannelImpl(agent_), v8_inspector::StringView()
-// v8-android package and v8 nuget do not share the same V8 version. A change in V8_inspector API forces us to add this
-// ifndef check. This will be fixed in a future nuget package update.
-#ifndef ANDROID
-                , v8_inspector::V8Inspector::kFullyTrusted
-#endif
-            );
+            session_ = inspector_->connect(1, new ChannelImpl(agent_), v8_inspector::StringView(), v8_inspector::V8Inspector::kFullyTrusted);
         }
 
         void DisconnectFrontend()

Core/Node-API/CMakeLists.txt

@@ -88,8 +88,9 @@ if(NAPI_BUILD_ABI)
             "Source/js_native_api_v8_internals.h")
 
         if(ANDROID)
-            set(V8_PACKAGE_NAME "v8-android-jit-nointl-nosnapshot")
-            set(V8_ANDROID_DIR "${CMAKE_CURRENT_BINARY_DIR}/${V8_PACKAGE_NAME}")
+            set(V8_PACKAGE_BASE_NAME "v8-android-jit-nointl-nosnapshot")
+            set(V8_PACKAGE_NAME "@babylonjs/${V8_PACKAGE_BASE_NAME}")
+            set(V8_ANDROID_DIR "${CMAKE_CURRENT_BINARY_DIR}/${V8_PACKAGE_BASE_NAME}")
             napi_install_android_package(v8 "dist/org/chromium" ${V8_ANDROID_DIR})
 
             set(INCLUDE_DIRECTORIES ${INCLUDE_DIRECTORIES}

Core/Node-API/Include/Engine/V8/napi/env.h

@@ -11,7 +11,7 @@
 #ifndef V8_31BIT_SMIS_ON_64BIT_ARCH
 #define V8_31BIT_SMIS_ON_64BIT_ARCH 1
 #endif
-#ifndef V8_ENABLE_SANDBOX
+#if !defined(ANDROID) && !defined(V8_ENABLE_SANDBOX)
 #define V8_ENABLE_SANDBOX 1
 #endif
 #endif

Core/Node-API/Source/js_native_api_v8_internals.h

@@ -24,7 +24,7 @@
 #ifndef V8_31BIT_SMIS_ON_64BIT_ARCH
 #define V8_31BIT_SMIS_ON_64BIT_ARCH 1
 #endif
-#ifndef V8_ENABLE_SANDBOX
+#if !defined(ANDROID) && !defined(V8_ENABLE_SANDBOX)
 #define V8_ENABLE_SANDBOX 1
 #endif
 #endif

Core/Node-API/package-v8.json

@@ -1,5 +1,5 @@
 {
   "dependencies": {
-    "v8-android-jit-nointl-nosnapshot": "11.1000.4"
+    "@babylonjs/v8-android-jit-nointl-nosnapshot": "11.110.1"
   }
 }