fix lint & update method name

Author: zhiyuanliang-ms

src/AzureAppConfigurationImpl.ts

@@ -449,7 +449,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
         // try refresh if any of watched settings is changed.
         let needRefresh = false;
         if (this.#watchAll) {
-            needRefresh = await this.#checkKeyValueCollectionChanged(this.#keyValueSelectors);
+            needRefresh = await this.#checkConfigurationSettingsChange(this.#keyValueSelectors);
         }
         for (const sentinel of this.#sentinels.values()) {
             const response = await this.#getConfigurationSetting(sentinel, {
@@ -483,7 +483,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
             return Promise.resolve(false);
         }
 
-        const needRefresh = await this.#checkKeyValueCollectionChanged(this.#featureFlagSelectors);
+        const needRefresh = await this.#checkConfigurationSettingsChange(this.#featureFlagSelectors);
         if (needRefresh) {
             await this.#loadFeatureFlags();
         }
@@ -497,7 +497,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
      * @param selectors - The @see PagedSettingSelector of the kev-value collection.
      * @returns true if key-value collection has changed, false otherwise.
      */
-    async #checkKeyValueCollectionChanged(selectors: PagedSettingSelector[]): Promise<boolean> {
+    async #checkConfigurationSettingsChange(selectors: PagedSettingSelector[]): Promise<boolean> {
         const funcToExecute = async (client) => {
             for (const selector of selectors) {
                 const listOptions: ListConfigurationSettingsOptions = {

test/refresh.test.ts

@@ -331,22 +331,22 @@ describe("dynamic refresh", function () {
                 refreshIntervalInMs: 2000
             }
         });
-        
+
         let refreshSuccessfulCount = 0;
         settings.onRefresh(() => {
             refreshSuccessfulCount++;
         });
 
         expect(settings).not.undefined;
         expect(settings.get("app.settings.fontColor")).eq("red");
-        
+
         await sleepInMs(2 * 1000 + 1);
         await settings.refresh();
         expect(refreshSuccessfulCount).eq(0); // no change in feature flags, because page etags are the same.
 
         // change key value
         restoreMocks();
-        let changedKVs = [
+        const changedKVs = [
             { value: "blue", key: "app.settings.fontColor" },
             { value: "40", key: "app.settings.fontSize" }
         ].map(createMockedKeyValue);