BatchManagementClient example uses ADAL, which is out of support in December 2022

[Chris-Johnston]

I've been referring to these samples to figure out how to use the BatchManagementClient. (The other Batch client doesn't support user-assigned managed identity) The package Microsoft.IdentityModel.Clients.ActiveDirectory is deprecated and will stop receiving updates in December 2022 (3 months as of writing).

azure-batch-samples/CSharp/AccountManagement/AccountManagement.csproj

Line 15 in 079a7d2

<PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="5.2.0" />

The sample should be updated to instead use Microsoft.Identity.Client, which would look something like this. It would also be great to update beyond .net462.

var cred = new DefaultAzureCredential(false); // I'm running this on an azure function, with system managed identity.
var token = cred.GetTokenAsync(new TokenRequestContext(new string[]
{
    "https://management.core.windows.net/",
}));
using var batchManagementClient = new BatchManagementClient(new TokenCredentials(token.Result.Token));

[BC89]

Is this going to be addressed? ADAL, really. FOR SHIZZZLLLEEE.

[TucoFernandes]

I'm having issues with this! In my institution we have certain users with different levels of access in a batch account. Since Batch do not use azure-identity we are having issues i.e. if I use DefaultCredentials I can't create the client! and get an error 'DefaultAzureCredential' object has no attribute 'signed_session'. But if I log in using the sharedKey I can't create a pool with a custom image I created! Is the Azure batch going to be upgraded to use azure-identity?!