impact: a private class field (Owner.#name) resolves under its # spelling

The resolver rewrote '#' to '.' for everything but methods, so Vault.#secret
became Vault..secret and #secret became secret: no spelling reached the field.
A '#' name is now looked up verbatim as a field before the rewrite.

JavaScript class fields were also indexed with no owner, so even a public
field's readers were only 'alongside' rows; the field now takes its class from
ownerTypeLinkHash (and its own id), as TypeScript's already do.

Golden cases for JS and TS, with controls: a private method, a public field,
and a same-named private field in another class.

Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
Co-Authored-By: Claude <noreply@anthropic.com>

Author: 3 people

plugins/axiomcode/skills/axiomcode/scripts/axiomcode-impact

@@ -427,6 +427,9 @@ class Impact:
         if '#' in verb:
             hit = self.g.q("SELECT id FROM symbols WHERE (display = ? OR qualified_name = ?) AND method_id IS NOT NULL", verb, verb)
             if hit: return [('method', verb + (f" ({len(hit)} declarations)" if len(hit) > 1 else ''), [x['id'] for x in hit])]
+            # …and a private FIELD (`Vault.#secret`, `#secret`) the same way: rewritten, it asked for `Vault..secret`
+            rows = self.field_rows(verb) if kind in (None, 'field') and re.search(r'(^|\.)#[A-Za-z_$]', verb) else []
+            if rows: return [('field', f"{rows[0]['kind']} {rows[0]['display']}" + (f" (+{len(rows)-1} declarations of that name)" if len(rows) > 1 else ''), rows)]
         base = re.sub(r'\(.*\)$', '', s).replace('#', '.').strip('.')
         if not (self.field_rows(base) or self.types(base, soft=True) or self.methods(base, soft=True)): base = base.replace('$', '.')   # Outer$Inner — unless $ is part of the name ($Gson$Types)
         m0 = re.match(r'^(.+)\.<new>$', base)

plugins/axiomcode/skills/axiomcode/scripts/axiomcode-index

@@ -123,7 +123,10 @@ A = {
     # each made the function or class it names look declared as a second kind, so `impact C` refused as ambiguous
     decls=[dict(file='all-javascript-variables.csv', only=lambda r: not r.get('ownerMethodLinkHash') and r.get('bindingRegime') not in ('IMPORT_BINDING', 'FUNCTION_DECLARATION_HOISTED', 'CLASS_TDZ') and not r.get('importLinkHash'),
                 kind=lambda r: 'const' if r.get('bindingRegime', '').startswith('CONST') else 'variable', name='name', owner=None, fileVia=('modules', 'ownerModuleLinkHash'), line='startLine', end='endLine'),
-           dict(file='all-javascript-fields.csv', kind=lambda r: 'field', name='name', owner=None, fileVia=('modules', 'ownerModuleLinkHash'), line='startLine', end='startLine')],
+           # a class field names its class by type id, not qualified name: without it the field had no owner, so
+           # `impact Vault.x` matched it only by qualified_name and every reader in the class was a name match at best
+           dict(file='all-javascript-fields.csv', id='jsFieldUniqueHash', kind=lambda r: 'field', name='name', owner=None, ownerType='ownerTypeLinkHash',
+                fileVia=('modules', 'ownerModuleLinkHash'), line='startLine', end='startLine')],
     # `const foo = () => …`: the variable's initializerExpressionLinkHash is the FUNCTION_EXPRESSION row whose
     # introducesDeclarationLinkHash is the method — two hops, where TypeScript has boundFunctionLinkHash in one
     boundNames=dict(file='all-javascript-variables.csv', name='name', only=lambda r: r.get('initializerKind') == 'FUNCTION',
@@ -372,7 +375,7 @@ for d in A['decls']:
         if d.get('only') and not d['only'](r): continue
         name = r.get(d['name'], '');
         if not name: continue
-        fp = file_of(r, d); od = owner_display(r.get(d['owner'], '')) if d.get('owner') else None
+        fp = file_of(r, d); od = owner_display(r.get(d['owner'], '')) if d.get('owner') else (tdisplay(r.get(d['ownerType'], '')) or None) if d.get('ownerType') else None
         ln = int(r.get(d['line']) or 0); en = int(r.get(d['end']) or ln)
         if (fp, ln, name) in bound_at: continue     # `const foo = () => …` is already the function foo
         sym.append((r.get(d['id']) if d.get('id') else None, name, (od + '.' if od else '') + name, d['kind'](r), (r.get('qualifiedName') or ((r.get(d['owner'], '') + '.') if d.get('owner') else (fp + '#')) + name), None, fp, ln, en, od, 1 if fp and TESTRE.search(fp) else 0, None, None))

tests/cases/javascript/private-class-field/case.json

@@ -0,0 +1,19 @@
+{"lang": "javascript", "src": "src",
+ "checks": [
+  {"why": "a private class field is written with its # (Vault.#secret): read as a member separator, the lookup asked for 'Vault..secret' and found nothing, though the field is in the graph under that very name",
+   "run": ["impact", "Vault.#secret"],
+   "want": ["change: field Vault.#secret", "Vault.reveal"],
+   "avoid": ["nothing named", "[in scope] Ledger.peek", "[resolved] Ledger.peek"]},
+  {"why": "the bare #secret names the private field too, in every class that declares one",
+   "run": ["impact", "#secret"],
+   "want": ["field Vault.#secret", "Vault.reveal", "Ledger.peek"],
+   "avoid": ["nothing named"]},
+  {"why": "control: a private METHOD written with its # still resolves to the method, not to a field",
+   "run": ["impact", "Vault.#hide"],
+   "want": ["change: Vault.#hide", "Vault.describe"],
+   "avoid": ["field"]},
+  {"why": "control: a public field is answered under its owner, and a sibling that does not touch it is not a reader",
+   "run": ["impact", "Vault.label"],
+   "want": ["change: field Vault.label", "Vault.#hide"],
+   "avoid": ["[in scope] Vault.reveal", "[resolved] Vault.reveal"]}
+ ]}

tests/cases/javascript/private-class-field/src/vault.js

@@ -0,0 +1,12 @@
+export class Vault {
+  #secret = 1;
+  label = 'vault';
+  reveal() { return this.#secret; }
+  #hide() { return this.label; }
+  describe() { return this.#hide(); }
+}
+
+export class Ledger {
+  #secret = 2;
+  peek() { return this.#secret; }
+}

tests/cases/typescript/private-class-field/case.json

@@ -0,0 +1,19 @@
+{"lang": "typescript", "src": "src",
+ "checks": [
+  {"why": "a private class field is written with its # (Vault.#secret): read as a member separator, the lookup asked for 'Vault..secret' and found nothing, though the field is in the graph under that very name",
+   "run": ["impact", "Vault.#secret"],
+   "want": ["change: field Vault.#secret", "Vault.reveal"],
+   "avoid": ["nothing named", "[in scope] Ledger.peek", "[resolved] Ledger.peek"]},
+  {"why": "the bare #secret names the private field too, in every class that declares one",
+   "run": ["impact", "#secret"],
+   "want": ["field Vault.#secret", "Vault.reveal", "Ledger.peek"],
+   "avoid": ["nothing named"]},
+  {"why": "control: a private METHOD written with its # still resolves to the method, not to a field",
+   "run": ["impact", "Vault.#hide"],
+   "want": ["change: Vault.#hide", "Vault.describe"],
+   "avoid": ["field"]},
+  {"why": "control: a public field is answered under its owner, and a sibling that does not touch it is not a reader",
+   "run": ["impact", "Vault.label"],
+   "want": ["change: field Vault.label", "Vault.#hide"],
+   "avoid": ["[in scope] Vault.reveal", "[resolved] Vault.reveal"]}
+ ]}

tests/cases/typescript/private-class-field/src/vault.ts

@@ -0,0 +1,12 @@
+export class Vault {
+  #secret: number = 1;
+  label: string = 'vault';
+  reveal(): number { return this.#secret; }
+  #hide() { return this.label; }
+  describe() { return this.#hide(); }
+}
+
+export class Ledger {
+  #secret: number = 2;
+  peek(): number { return this.#secret; }
+}