Repository navigation
Commit 7c550fa
committed
bundle: a relation that names a field makes that field listed (#890)
`fields` holds every client field, but a LIBRARY field only when something references it,
and the only thing that counted was a field_access row. config_binding names the field a
configuration key binds to, which is a statement that the field matters, and it did not
count, so its rows pointed at ids the table does not hold.
Rather than teach the language-neutral bundler about a Java relation, the adapter now
declares which of its relations name a field and in which column, and build.ts folds those
ids into the same wanted set field_access already fills. Java declares config-binding.csv
column 3.
Measured on 8 Spring Boot services solved with one starter as --library:
config_binding field ids 154
dangling before 112
dangling after 8
fields table 1427 -> 1531 (+104)
call_edges 8315 -> 8315
The residual 8 are a different fault and deliberately not addressed here: those ids appear
in no all-fields.csv on either side, so no amount of listing reaches them. They are worth
their own issue once someone works out which rule mints them.
Suite 56 passed, 0 failed, no golden changes.1 parent 8357ef5 commit 7c550fa
2 files changed
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
202 | 211 | | |
203 | 212 | | |
204 | 213 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
98 | 109 | | |
99 | 110 | | |
100 | 111 | | |
| |||
126 | 137 | | |
127 | 138 | | |
128 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
129 | 144 | | |
130 | 145 | | |
131 | 146 | | |
| |||
0 commit comments