Skip to content

Commit e8ae242

Browse files
committed
usb: typec: tipd: Be more verbose about errors
Make sure to print out error codes and log exactly what packet sizes were received in case of a mismatch. This is very useful for debugging badness. Signed-off-by: Hector Martin <marcan@marcan.st>
1 parent ee12235 commit e8ae242

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

drivers/usb/typec/tipd/core.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,15 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
133133
return regmap_raw_read(tps->regmap, reg, val, len);
134134

135135
ret = regmap_raw_read(tps->regmap, reg, data, len + 1);
136-
if (ret)
136+
if (ret) {
137+
dev_err(tps->dev, "regmap_raw_read returned %d\n", ret);
137138
return ret;
139+
}
138140

139-
if (data[0] < len)
141+
if (data[0] < len) {
142+
dev_err(tps->dev, "expected %zu bytes, got %d\n", len, data[0]);
140143
return -EIO;
144+
}
141145

142146
memcpy(val, &data[1], len);
143147
return 0;
@@ -416,7 +420,7 @@ static bool tps6598x_read_status(struct tps6598x *tps, u32 *status)
416420

417421
ret = tps6598x_read32(tps, TPS_REG_STATUS, status);
418422
if (ret) {
419-
dev_err(tps->dev, "%s: failed to read status\n", __func__);
423+
dev_err(tps->dev, "%s: failed to read status: %d\n", __func__, ret);
420424
return false;
421425
}
422426
trace_tps6598x_status(*status);

0 commit comments

Comments
 (0)