Skip to content

Commit bbef3c1

Browse files
jannaumarcan
authored andcommitted
drm: apple: iomfb: Increase modeset tiemout to 8.5 seconds
DCP itself uses with the 13.5 firmware a timeout of 8 seconds for modesets. Using a longer timeout prevents overlapping calls to dcp and might improve reliabilty with slower displays. Signed-off-by: Janne Grunau <j@jannau.net>
1 parent 462a4ba commit bbef3c1

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

drivers/gpu/drm/apple/iomfb_template.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1330,9 +1330,14 @@ void DCP_FW_NAME(iomfb_flush)(struct apple_dcp *dcp, struct drm_crtc *crtc, stru
13301330
dcp_set_digital_out_mode(dcp, false, &dcp->mode,
13311331
complete_set_digital_out_mode, cookie);
13321332

1333+
/*
1334+
* The DCP firmware has an internal timeout of ~8 seconds for
1335+
* modesets. Add an extra 500ms to safe side that the modeset
1336+
* call has returned.
1337+
*/
13331338
dev_dbg(dcp->dev, "%s - wait for modeset", __func__);
13341339
ret = wait_for_completion_timeout(&cookie->done,
1335-
msecs_to_jiffies(2500));
1340+
msecs_to_jiffies(8500));
13361341

13371342
kref_put(&cookie->refcount, release_wait_cookie);
13381343

0 commit comments

Comments
 (0)