Packaging on Arch Linux require -Wno-incompatible-pointer-types

[FabioLolix]

Hi, packaging on Arch Linux (latest commit) fail if -Wno-incompatible-pointer-types is not passed, this is happening since GCC 14.1

[ 49%] Building C object lib/libzsync/CMakeFiles/libzsync.dir/sha1.c.o
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c: In function 'zsync_get_urls':
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c:460:18: error: returning 'char **' from a function with incompatible return type 'const char * const*' [-Wincompatible-pointer-types]
  460 |         return zs->zurl;
      |                ~~^~~~~~
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c:465:18: error: returning 'char **' from a function with incompatible return type 'const char * const*' [-Wincompatible-pointer-types]
  465 |         return zs->url;
      |                ~~^~~~~
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c: In function 'zsync_receive_data_compressed':
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c:945:22: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  945 |     zr->strm.next_in = buf;
      |                      ^
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c:950:43: error: passing argument 4 of 'zsync_configure_zstream_for_zdata' from incompatible pointer type [-Wincompatible-pointer-types]
  950 |                                           &(zr->outoffset));
      |                                           ^~~~~~~~~~~~~~~~
      |                                           |
      |                                           off_t * {aka long int *}
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c:791:65: note: expected 'long long int *' but argument is of type 'off_t *' {aka 'long int *'}
  791 |                                        long zoffset, long long *poutoffset) {
      |                                                      ~~~~~~~~~~~^~~~~~~~~~
/home/fabio/Dev/Github/PKGBUILD-AUR_fix/z/zsync2-git/src/zsync2/lib/libzsync/zsync.c:962:26: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  962 |         zr->strm.next_in = buf;
      |                          ^
make[2]: *** [lib/libzsync/CMakeFiles/libzsync.dir/build.make:76: lib/libzsync/CMakeFiles/libzsync.dir/zsync.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1034: lib/libzsync/CMakeFiles/libzsync.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
In function 'SHA1Update',

[TheAssassin]

Please don't hesitate to open a PR.

[FabioLolix]

I don't have the knowledge for that sorry, the best I can do is adding or removing headers include

[Technetium1]

@FabioLolix now also requires -DCMAKE_POLICY_VERSION_MINIMUM="3.5"