Skip to content

Commit 4faab6b

Browse files
1951FDGhannesa2
authored andcommitted
Optimize recycledViewPool using a higher value
Text fields occupy small height, the default of 5 being already very low
1 parent cf3d45b commit 4faab6b

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

LogcatCoreLib/src/main/java/info/hannes/logcat/base/LogBaseFragment.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ abstract class LogBaseFragment : Fragment() {
4848

4949
logsRecycler = view.findViewById<RecyclerView>(R.id.log_recycler).also {
5050
it.layoutManager = LinearLayoutManager(it.context)
51+
it.recycledViewPool.setMaxRecycledViews(R.layout.item_log, DEFAULT_MAX_SCRAP)
5152
}
5253
// empty adapter to avoid "E/RecyclerView﹕ No adapter attached; skipping layou..."
5354
logListAdapter = LogListAdapter(mutableListOf(), currentFilter)
@@ -244,6 +245,8 @@ abstract class LogBaseFragment : Fragment() {
244245

245246
companion object {
246247

248+
private const val DEFAULT_MAX_SCRAP = 5 * 10
249+
247250
private const val MAIL_ATTACHMENT_TYPE = "text/plain"
248251

249252
const val FILE_NAME = "targetFilename"

LogcatCoreLib/src/main/java/info/hannes/logcat/base/LogListAdapter.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ class LogListAdapter(private var completeLogs: MutableList<String>, filter: Stri
108108
}
109109
}
110110

111+
override fun getItemViewType(position: Int): Int {
112+
return R.layout.item_log
113+
}
114+
111115
override fun getItemCount(): Int = filterLogs.size
112116

113117
/**

0 commit comments

Comments
 (0)