Handle RawTypeDataSetDetector for datasets in lib

Author: hannesa2

app/build.gradle.kts

@@ -46,6 +46,9 @@ android {
     testOptions {
         animationsDisabled = true
     }
+    lint {
+        lintConfig = file("lint.xml")
+    }
     packaging {
         jniLibs {
             // androidx.graphics:graphics-path ships a .so that llvm-strip cannot process;

app/lint.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Lint suppressions for the sample/demo app module.
+    These issues are intentionally suppressed here because this module
+    demonstrates legacy API usage. The rules still apply to library consumers.
+-->
+<lint>
+    <!-- Demo app intentionally uses LineDataSet without explicit type args for brevity. -->
+    <issue id="RawTypeDataSet" severity="ignore" />
+</lint>
+

chartLib/src/main/kotlin/info/appdev/charting/data/ChartData.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.data
 
+import android.annotation.SuppressLint
 import android.graphics.Typeface
 import info.appdev.charting.components.YAxis.AxisDependency
 import info.appdev.charting.formatter.IValueFormatter
@@ -440,6 +441,7 @@ abstract class ChartData<T : IDataSet<out EntryFloat>> : Serializable {
      * specified index. Returns true if an Entry was removed, false if no Entry
      * was found that meets the specified requirements.
      */
+    @SuppressLint("RawTypeDataSet")
     open fun removeEntry(xValue: Float, dataSetIndex: Int): Boolean {
         if (dataSetIndex >= dataSets.size) {
             return false

chartLib/src/main/kotlin/info/appdev/charting/data/DataSet.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.data
 
+import android.annotation.SuppressLint
 import timber.log.Timber
 import java.io.Serializable
 import kotlin.math.abs
@@ -130,7 +131,7 @@ abstract class DataSet<T : BaseEntry<Float>>(
      */
     abstract fun copy(): DataSet<T>?
 
-    protected fun copy(dataSet: DataSet<*>) {
+    protected fun copy(@SuppressLint("RawTypeDataSet") dataSet: DataSet<*>) {
         super.copy(dataSet)
     }
 

chartLib/src/main/kotlin/info/appdev/charting/data/LineDataSet.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.data
 
+import android.annotation.SuppressLint
 import android.content.Context
 import android.graphics.Color
 import android.graphics.DashPathEffect
@@ -84,7 +85,7 @@ open class LineDataSet<T : BaseEntry<Float>>(yVals: MutableList<T> = mutableList
         return copied as DataSet<T>
     }
 
-    protected fun copy(lineDataSet: LineDataSet<*>) {
+    protected fun copy(@SuppressLint("RawTypeDataSet") lineDataSet: LineDataSet<*>) {
         super.copy((lineDataSet as BaseDataSet<*>?)!!)
         lineDataSet.circleColors = this.circleColors
         lineDataSet.mCircleHoleColor = mCircleHoleColor

chartLib/src/main/kotlin/info/appdev/charting/highlight/ChartHighlighter.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.highlight
 
+import android.annotation.SuppressLint
 import info.appdev.charting.components.YAxis.AxisDependency
 import info.appdev.charting.data.ChartData
 import info.appdev.charting.data.DataSet
@@ -115,7 +116,7 @@ open class ChartHighlighter<T : BarLineScatterCandleBubbleDataProvider<*>>(prote
      */
     @Suppress("SameParameterValue")
     protected open fun buildHighlights(
-        set: IDataSet<*>,
+        @SuppressLint("RawTypeDataSet") set: IDataSet<*>,
         dataSetIndex: Int,
         xVal: Float,
         rounding: DataSet.Rounding?

chartLib/src/main/kotlin/info/appdev/charting/highlight/HorizontalBarHighlighter.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.highlight
 
+import android.annotation.SuppressLint
 import info.appdev.charting.data.DataSet
 import info.appdev.charting.data.EntryFloat
 import info.appdev.charting.interfaces.dataprovider.BarDataProvider
@@ -32,7 +33,7 @@ class HorizontalBarHighlighter(dataProvider: BarDataProvider) : BarHighlighter(d
         return null
     }
 
-    override fun buildHighlights(set: IDataSet<*>, dataSetIndex: Int, xVal: Float, rounding: DataSet.Rounding?): MutableList<Highlight> {
+    override fun buildHighlights(@SuppressLint("RawTypeDataSet") set: IDataSet<*>, dataSetIndex: Int, xVal: Float, rounding: DataSet.Rounding?): MutableList<Highlight> {
         val highlights = ArrayList<Highlight>()
 
         var entries = set.getEntriesForXValue(xVal)?.map { it as EntryFloat }?.toMutableList()

chartLib/src/main/kotlin/info/appdev/charting/listener/OnDrawListener.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.listener
 
+import android.annotation.SuppressLint
 import info.appdev.charting.data.DataSet
 import info.appdev.charting.data.EntryFloat
 
@@ -25,5 +26,5 @@ interface OnDrawListener {
      *
      * @param dataSet the last drawn DataSet
      */
-    fun onDrawFinished(dataSet: DataSet<*>)
+    fun onDrawFinished(@SuppressLint("RawTypeDataSet") dataSet: DataSet<*>)
 }

chartLib/src/main/kotlin/info/appdev/charting/renderer/BarLineScatterCandleBubbleRenderer.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.renderer
 
+import android.annotation.SuppressLint
 import info.appdev.charting.animation.ChartAnimator
 import info.appdev.charting.data.DataSet
 import info.appdev.charting.data.BaseEntry
@@ -22,7 +23,7 @@ abstract class BarLineScatterCandleBubbleRenderer(
     /**
      * Returns true if the DataSet values should be drawn, false if not.
      */
-    protected fun shouldDrawValues(set: IDataSet<*>): Boolean {
+    protected fun shouldDrawValues(@SuppressLint("RawTypeDataSet") set: IDataSet<*>): Boolean {
         return set.isVisible && (set.isDrawValues || set.isDrawIcons)
     }
 

chartLib/src/main/kotlin/info/appdev/charting/renderer/DataRenderer.kt

@@ -1,5 +1,6 @@
 package info.appdev.charting.renderer
 
+import android.annotation.SuppressLint
 import android.graphics.Canvas
 import android.graphics.Color
 import android.graphics.Paint
@@ -70,7 +71,7 @@ abstract class DataRenderer(
      * Applies the required styling (provided by the DataSet) to the value-paint
      * object.
      */
-    protected fun applyValueTextStyle(set: IDataSet<*>) {
+    protected fun applyValueTextStyle(@SuppressLint("RawTypeDataSet") set: IDataSet<*>) {
         paintValues.typeface = set.valueTypeface
         paintValues.textSize = set.valueTextSize
     }