competency: we need to use column_id when setting default values.

Author: dbrnz

mapserver/competency/definition.py

@@ -269,11 +269,11 @@ def make_sql(self, request: QueryRequest) -> tuple[str, list[str]]:
                 conditions[param_def.condition].append(where_condition)
                 used_columns.append(column_id)
         # NB. req_params might/will not have entries for default params
-        for column, param_def in self.__parameters.items():
-            if column not in used_columns:
+        for column_id, param_def in self.__parameters.items():
+            if column_id not in used_columns:
                 if not param_def.optional:
-                    raise ValueError(f'Required parameter must have a value: {column}')
-                where_condition = f'{column} = ({param_def.default_sql})'
+                    raise ValueError(f'Required parameter must have a value: {column_id}')
+                where_condition = f'{param_def.column} = ({param_def.default_sql})'
                 conditions[param_def.condition].append(where_condition)
         sql = self.__sql_defn.sql
         for condition, expressions in conditions.items():