Move deprecation notice to element definition

The notice is static per element definition, not different per
element record. We can display the notice where we just
display the definition that way.

Author: tvdeyen

app/decorators/alchemy/element_editor.rb

@@ -77,49 +77,6 @@ def respond_to?(*args, **kwargs)
       super
     end
 
-    # Returns a deprecation notice for elements marked deprecated
-    #
-    # You can either use localizations or pass a String as notice
-    # in the element definition.
-    #
-    # == Custom deprecation notices
-    #
-    # Use general element deprecation notice
-    #
-    #     - name: old_element
-    #       deprecated: true
-    #
-    # Add a translation to your locale file for a per element notice.
-    #
-    #     en:
-    #       alchemy:
-    #         element_deprecation_notices:
-    #           old_element: Foo baz widget is deprecated
-    #
-    # or use the global translation that apply to all deprecated elements.
-    #
-    #     en:
-    #       alchemy:
-    #         element_deprecation_notice: Foo baz widget is deprecated
-    #
-    # or pass string as deprecation notice.
-    #
-    #     - name: old_element
-    #       deprecated: This element will be removed soon.
-    #
-    def deprecation_notice
-      case definition.deprecated
-      when String
-        definition.deprecated
-      when TrueClass
-        Alchemy.t(
-          name,
-          scope: :element_deprecation_notices,
-          default: Alchemy.t(:element_deprecated)
-        )
-      end
-    end
-
     private
 
     def find_or_create_ingredient(definition)

app/models/alchemy/element.rb

@@ -106,7 +106,7 @@ class Element < BaseRecord
     scope :not_nested, -> { where(parent_element_id: nil) }
 
     delegate :restricted?, to: :page, allow_nil: true
-    delegate :has_hint?, :hint, to: :definition
+    delegate :deprecation_notice, :has_hint?, :hint, to: :definition
 
     # Concerns
     include Definitions

app/models/alchemy/element_definition.rb

@@ -109,6 +109,49 @@ def ingredients
       super.map(&:with_indifferent_access)
     end
 
+    # Returns a deprecation notice for elements marked deprecated
+    #
+    # You can either use localizations or pass a String as notice
+    # in the element definition.
+    #
+    # == Custom deprecation notices
+    #
+    # Use general element deprecation notice
+    #
+    #     - name: old_element
+    #       deprecated: true
+    #
+    # Add a translation to your locale file for a per element notice.
+    #
+    #     en:
+    #       alchemy:
+    #         element_deprecation_notices:
+    #           old_element: Foo baz widget is deprecated
+    #
+    # or use the global translation that apply to all deprecated elements.
+    #
+    #     en:
+    #       alchemy:
+    #         element_deprecation_notice: Foo baz widget is deprecated
+    #
+    # or pass string as deprecation notice.
+    #
+    #     - name: old_element
+    #       deprecated: This element will be removed soon.
+    #
+    def deprecation_notice
+      case deprecated
+      when String
+        deprecated
+      when TrueClass
+        Alchemy.t(
+          name,
+          scope: :element_deprecation_notices,
+          default: Alchemy.t(:element_deprecated)
+        )
+      end
+    end
+
     private
 
     def hint_translation_scope

spec/decorators/alchemy/element_editor_spec.rb

@@ -185,57 +185,4 @@
 
     it { is_expected.to be(false) }
   end
-
-  describe "deprecation_notice" do
-    subject { element_editor.deprecation_notice }
-
-    context "when element is not deprecated" do
-      let(:element) { build(:alchemy_element, name: "article") }
-
-      it { is_expected.to be_nil }
-    end
-
-    context "when element is deprecated" do
-      let(:element) { build(:alchemy_element, name: "old") }
-
-      context "with custom element translation" do
-        it { is_expected.to eq("Old element is deprecated") }
-      end
-
-      context "without custom element translation" do
-        let(:element) { build(:alchemy_element, name: "old_too") }
-
-        before do
-          allow(element).to receive(:definition) do
-            Alchemy::ElementDefinition.new(
-              name: "old_too",
-              deprecated: true
-            )
-          end
-        end
-
-        it do
-          is_expected.to eq(
-            "WARNING! This element is deprecated and will be removed soon. " \
-            "Please do not use it anymore."
-          )
-        end
-      end
-
-      context "with String as deprecation" do
-        let(:element) { build(:alchemy_element, name: "old_string") }
-
-        before do
-          allow(element).to receive(:definition) do
-            Alchemy::ElementDefinition.new(
-              name: "old_string",
-              deprecated: "Foo baz widget"
-            )
-          end
-        end
-
-        it { is_expected.to eq("Foo baz widget") }
-      end
-    end
-  end
 end

spec/models/alchemy/element_definition_spec.rb

@@ -46,6 +46,41 @@ module Alchemy
       end
     end
 
+    describe "#deprecation_notice" do
+      subject { definition.deprecation_notice }
+
+      context "when element is not deprecated" do
+        let(:definition) { described_class.new(name: "article") }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "when element is deprecated" do
+        let(:definition) { described_class.new(name: "old", deprecated: true) }
+
+        context "with custom element translation" do
+          it { is_expected.to eq("Old element is deprecated") }
+        end
+
+        context "without custom element translation" do
+          let(:definition) { described_class.new(name: "old_too", deprecated: true) }
+
+          it do
+            is_expected.to eq(
+              "WARNING! This element is deprecated and will be removed soon. " \
+              "Please do not use it anymore."
+            )
+          end
+        end
+
+        context "with String as deprecation" do
+          let(:definition) { described_class.new(name: "old_string", deprecated: "Foo baz widget") }
+
+          it { is_expected.to eq("Foo baz widget") }
+        end
+      end
+    end
+
     describe ".all" do
       # skip memoization
       before { ElementDefinition.instance_variable_set(:@definitions, nil) }