Delegate PageDefinition#blank? to name

Before we converted this into a model we used an empty
hash as definition of a page that misses its definition.

Author: tvdeyen

app/models/alchemy/page/page_natures.rb

@@ -83,7 +83,7 @@ def definition
         definition = PageDefinition.get(page_layout)
         if definition.nil?
           log_warning "Page definition for `#{page_layout}` not found. Please check `page_layouts.yml` file."
-          return PageDefinition.new(name: page_layout)
+          return PageDefinition.new
         end
         definition
       end

app/models/alchemy/page_definition.rb

@@ -28,6 +28,7 @@ class PageDefinition
       }
 
     delegate :[], to: :attributes
+    delegate :blank?, to: :name
 
     class << self
       # Returns all page layouts.

spec/models/alchemy/page_definition_spec.rb

@@ -22,6 +22,22 @@ module Alchemy
       it { is_expected.to have_key(:hint) }
     end
 
+    describe "#blank?" do
+      subject { definition.blank? }
+
+      context "with name given" do
+        let(:definition) { described_class.new(name: "standard") }
+
+        it { is_expected.to be(false) }
+      end
+
+      context "without name given" do
+        let(:definition) { described_class.new }
+
+        it { is_expected.to be(true) }
+      end
+    end
+
     describe "validations" do
       it { is_expected.to validate_presence_of(:name) }
     end

spec/models/alchemy/page_spec.rb

@@ -1214,20 +1214,22 @@ module Alchemy
       context "if the page layout could not be found in the definition file" do
         let(:page) { build_stubbed(:alchemy_page, page_layout: "notexisting") }
 
-        it "it loggs a warning." do
+        it "it logs a warning." do
           expect(Alchemy::Logger).to receive(:warn)
           page.definition
         end
 
-        it "it returns empty hash." do
+        it "it returns empty definition." do
           expect(page.definition).to be_an(Alchemy::PageDefinition)
-          expect(page.definition.name).to eq("notexisting")
+          expect(page.definition.name).to be_nil
         end
       end
 
-      context "for a language root page" do
-        it "it returns the page layout definition as hash." do
-          expect(language_root.definition.name).to eq("index")
+      context "for a page with existing definition" do
+        let(:page) { build_stubbed(:alchemy_page) }
+
+        it "it returns the page layout definition." do
+          expect(page.definition.name).to eq("standard")
         end
       end
     end